Support #18308
closed
enable CollectionVersioning by default
Description
there's two relevant configuration options here
CollectionVersioning
PreserveVersionIfIdle
The current defaults are
CollectionVersioning: false
PreserveVersionIfIdle: -1s
This is pretty confusing because to enable versioning on regular updates you have both set CollectionVersioning: true and PreserveVersionIfIdle >= 0
(it took me 3 tries to get this right to enable it on playground).
Suggest "CollectionVersioning: true" by default and
and either always snapshot:
PreserveVersionIfIdle: 0s
or snapshot on explicit preserve_version:
PreserveVersionIfIdle: -1s
Updated by Peter Amstutz over 2 years ago
- Status changed from New to In Progress
Updated by Peter Amstutz over 2 years ago
- Status changed from In Progress to New
- Subject changed from enable CollectionVersioning by default to enable CollectionVersioning by default?
- Tracker changed from Bug to Support
Updated by Peter Amstutz over 2 years ago
- Subject changed from enable CollectionVersioning by default? to enable CollectionVersioning by default
Updated by Peter Amstutz over 2 years ago
- Target version changed from 2021-11-10 sprint to 2021-11-24 sprint
Updated by Peter Amstutz over 2 years ago
- Assigned To changed from Peter Amstutz to Ward Vandewege
Updated by Ward Vandewege over 2 years ago
- Status changed from New to In Progress
Ready for review at ccc7d1cab2d29e117be187cb23a86f98ece38102 on branch 18308-enable-collection-versioning
Tests are running at developer-run-tests: #2809
Updated by Peter Amstutz over 2 years ago
Ward Vandewege wrote:
Ready for review at ccc7d1cab2d29e117be187cb23a86f98ece38102 on branch 18308-enable-collection-versioning
Tests are running at developer-run-tests: #2809
Ward Vandewege wrote:
Ready for review at ccc7d1cab2d29e117be187cb23a86f98ece38102 on branch 18308-enable-collection-versioning
Tests are running at developer-run-tests: #2809
The changes LGTM but not sure what's going on with run-tests-remainder there, perhaps a flaky test?
Updated by Ward Vandewege over 2 years ago
Peter Amstutz wrote:
Ward Vandewege wrote:
Ready for review at ccc7d1cab2d29e117be187cb23a86f98ece38102 on branch 18308-enable-collection-versioning
Tests are running at developer-run-tests: #2809
The changes LGTM but not sure what's going on with run-tests-remainder there, perhaps a flaky test?
Hmm, yes, I re-ran at developer-run-tests-remainder: #2928 , and that one passed. I will merge this.
Updated by Ward Vandewege over 2 years ago
- % Done changed from 0 to 100
- Status changed from In Progress to Resolved
Applied in changeset arvados|db8fac04e5a7fb21bb91be59c507d6771e50c85a.