Bug #18313: [arvbox] should use our standard golang version for bootstrapping - Arvados

Actions

Copy link

Bug #18313

closed

[arvbox] should use our standard golang version for bootstrapping

Added by Ward Vandewege about 3 years ago. Updated almost 3 years ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Ward Vandewege

Category:

Target version:

2021-11-10 sprint

Story points:

Release:

Arvados 2.3.1

Release relationship:

Auto

Description

Arvbox bootstraps with `arvados-server install -type test`. It needs to build that binary first, which requires a Go compiler. Currently, the source has a specific version pinned in the arvbox Dockerfile. The canonical Go version is in `lib/install/deps.go`.

Make arvbox look up that version and use it, always.

Subtasks 1 (0 open — 1 closed)

Actions

Copy link

Updated by Ward Vandewege about 3 years ago

Status changed from New to In Progress

Actions

Copy link

Updated by Ward Vandewege about 3 years ago

Description updated (diff)

Actions

Copy link

Updated by Ward Vandewege about 3 years ago

ready for review at 3ce7895505f99de703ec750e4b0bf10334522b2d on branch 18313-arvbox-bootstrap-go-version

I tested this locally by running

WORKSPACE=... ./build/run-build-docker-images.sh

Actions

Copy link

Updated by Tom Clegg about 3 years ago

LGTM

Extra thought: might save some time for our future selves to add a test in lib/install that confirms grep|awk prints the right version -- so if someone changes the syntax or something, the test fails with a comment that the arvbox scripts need to be kept in sync.

Actions

Copy link

Updated by Ward Vandewege about 3 years ago

Tom Clegg wrote:

LGTM

Extra thought: might save some time for our future selves to add a test in lib/install that confirms grep|awk prints the right version -- so if someone changes the syntax or something, the test fails with a comment that the arvbox scripts need to be kept in sync.

Good idea! Implemented in a357f5f197dbe54314608d4c5acbdd9e1959afba on branch 18313-arvbox-bootstrap-go-version

Tests are running at developer-run-tests: #2768

Actions

Copy link

Updated by Tom Clegg about 3 years ago

Looks like source:tools/arvbox/lib/arvbox/docker/Dockerfile.base still has grep 'goversion :=', needs to update to const goversion = -- besides that LGTM, thanks!

Actions

Copy link

Updated by Ward Vandewege about 3 years ago

Tom Clegg wrote:

Looks like source:tools/arvbox/lib/arvbox/docker/Dockerfile.base still has grep 'goversion :=', needs to update to const goversion = -- besides that LGTM, thanks!

Oh wow that is just leftover, no longer needed. Pushed fix in 5e864400e2f82db117c15eaac4c7c5c3ad913bd6 and tests are at developer-run-tests: #2769

Actions

Copy link