Project

General

Profile

Actions

Bug #18313

closed

[arvbox] should use our standard golang version for bootstrapping

Added by Ward Vandewege 8 months ago. Updated 7 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
11/01/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Arvbox bootstraps with `arvados-server install -type test`. It needs to build that binary first, which requires a Go compiler. Currently, the source has a specific version pinned in the arvbox Dockerfile. The canonical Go version is in `lib/install/deps.go`.

Make arvbox look up that version and use it, always.


Subtasks 1 (0 open1 closed)

Task #18314: review 18313-arvbox-bootstrap-go-versionResolvedWard Vandewege11/01/2021

Actions
Actions #1

Updated by Ward Vandewege 8 months ago

  • Status changed from New to In Progress
Actions #2

Updated by Ward Vandewege 8 months ago

  • Description updated (diff)
Actions #3

Updated by Ward Vandewege 8 months ago

ready for review at 3ce7895505f99de703ec750e4b0bf10334522b2d on branch 18313-arvbox-bootstrap-go-version

I tested this locally by running

WORKSPACE=... ./build/run-build-docker-images.sh
Actions #4

Updated by Tom Clegg 8 months ago

LGTM

Extra thought: might save some time for our future selves to add a test in lib/install that confirms grep|awk prints the right version -- so if someone changes the syntax or something, the test fails with a comment that the arvbox scripts need to be kept in sync.

Actions #5

Updated by Ward Vandewege 8 months ago

Tom Clegg wrote:

LGTM

Extra thought: might save some time for our future selves to add a test in lib/install that confirms grep|awk prints the right version -- so if someone changes the syntax or something, the test fails with a comment that the arvbox scripts need to be kept in sync.

Good idea! Implemented in a357f5f197dbe54314608d4c5acbdd9e1959afba on branch 18313-arvbox-bootstrap-go-version

Tests are running at developer-run-tests: #2768

Actions #6

Updated by Tom Clegg 8 months ago

Looks like source:tools/arvbox/lib/arvbox/docker/Dockerfile.base still has grep 'goversion :=', needs to update to const goversion = -- besides that LGTM, thanks!

Actions #7

Updated by Ward Vandewege 8 months ago

Tom Clegg wrote:

Looks like source:tools/arvbox/lib/arvbox/docker/Dockerfile.base still has grep 'goversion :=', needs to update to const goversion = -- besides that LGTM, thanks!

Oh wow that is just leftover, no longer needed. Pushed fix in 5e864400e2f82db117c15eaac4c7c5c3ad913bd6 and tests are at developer-run-tests: #2769

Actions #8

Updated by Anonymous 8 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved
Actions #9

Updated by Peter Amstutz 7 months ago

  • Release set to 45
Actions

Also available in: Atom PDF