Bug #18313
closed
[arvbox] should use our standard golang version for bootstrapping
Added by Ward Vandewege about 3 years ago.
Updated almost 3 years ago.
Release relationship:
Auto
Description
Arvbox bootstraps with `arvados-server install -type test`. It needs to build that binary first, which requires a Go compiler. Currently, the source has a specific version pinned in the arvbox Dockerfile. The canonical Go version is in `lib/install/deps.go`.
Make arvbox look up that version and use it, always.
- Status changed from New to In Progress
- Description updated (diff)
LGTM
Extra thought: might save some time for our future selves to add a test in lib/install that confirms grep|awk
prints the right version -- so if someone changes the syntax or something, the test fails with a comment that the arvbox scripts need to be kept in sync.
Tom Clegg wrote:
LGTM
Extra thought: might save some time for our future selves to add a test in lib/install that confirms grep|awk
prints the right version -- so if someone changes the syntax or something, the test fails with a comment that the arvbox scripts need to be kept in sync.
Good idea! Implemented in a357f5f197dbe54314608d4c5acbdd9e1959afba on branch 18313-arvbox-bootstrap-go-version
Tests are running at developer-run-tests: #2768
- % Done changed from 0 to 100
- Status changed from In Progress to Resolved
Also available in: Atom
PDF