https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422021-11-05T19:42:22ZArvadosArvados - Bug #18340: Deleting 'role' and 'filter' groups should delete them immediatelyhttps://dev.arvados.org/issues/18340?journal_id=982832021-11-05T19:42:22ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/98283/diff?detail_id=94943">diff</a>)</li></ul> Arvados - Bug #18340: Deleting 'role' and 'filter' groups should delete them immediatelyhttps://dev.arvados.org/issues/18340?journal_id=984242021-11-10T16:18:42ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Lucas Di Pentima</i></li></ul> Arvados - Bug #18340: Deleting 'role' and 'filter' groups should delete them immediatelyhttps://dev.arvados.org/issues/18340?journal_id=986612021-11-16T19:42:35ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #18340: Deleting 'role' and 'filter' groups should delete them immediatelyhttps://dev.arvados.org/issues/18340?journal_id=986982021-11-17T11:31:20ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Updates at <a class="changeset" title="18340: Only trash project groups on delete calls. Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentim..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/43d9cc591e4207501d608d7b2ca1e7687d92825e">43d9cc591</a> - branch <code>18340-delete-role-filter-groups</code><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-run-tests/2802/"<a href="https://ci.arvados.org/job/developer-run-tests/2802/">developer-run-tests: #2802 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=2802" alt="" /></a></a></p>
<ul>
<li>Only use <code>TrashableController.destroy</code> on <code>project</code> groups.</li>
<li>Adds test.</li>
</ul> Arvados - Bug #18340: Deleting 'role' and 'filter' groups should delete them immediatelyhttps://dev.arvados.org/issues/18340?journal_id=987072021-11-17T15:00:18ZWard Vandewegeward@curii.com
<ul></ul><p>Lucas Di Pentima wrote:</p>
<blockquote>
<p>Updates at <a class="changeset" title="18340: Only trash project groups on delete calls. Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentim..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/43d9cc591e4207501d608d7b2ca1e7687d92825e">43d9cc591</a> - branch <code>18340-delete-role-filter-groups</code><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-run-tests/2802/"<a href="https://ci.arvados.org/job/developer-run-tests/2802/">developer-run-tests: #2802 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=2802" alt="" /></a></a></p>
<ul>
<li>Only use <code>TrashableController.destroy</code> on <code>project</code> groups.</li>
<li>Adds test.</li>
</ul>
</blockquote>
<p>Just one question, why the removal of `protected` on line 354? Otherwise, LGTM, thanks!</p> Arvados - Bug #18340: Deleting 'role' and 'filter' groups should delete them immediatelyhttps://dev.arvados.org/issues/18340?journal_id=987112021-11-17T15:04:30ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Just for the record: the <code>protected</code> declaration was duplicated on that file.</p> Arvados - Bug #18340: Deleting 'role' and 'filter' groups should delete them immediatelyhttps://dev.arvados.org/issues/18340?journal_id=987142021-11-17T15:17:19ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset arvados-private:commit:arvados|2a13c742cdca6fbae46a9ce1c6ae044633d03ce3.</p> Arvados - Bug #18340: Deleting 'role' and 'filter' groups should delete them immediatelyhttps://dev.arvados.org/issues/18340?journal_id=987422021-11-17T19:23:28ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>45</i></li></ul>