Project

General

Profile

Actions

Bug #18340

closed

Deleting 'role' and 'filter' groups should delete them immediately

Added by Peter Amstutz over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Story points:
-
Release relationship:
Auto

Description

originally brought up in #18339

side Q: how does should trash interact with 'role' groups? It appears a trashed 'role' group continues to be traversed for permissions until it is actually deleted from the system. Consider whether trashing a role group should either (a) not be allowed if there are outgoing permissions, (b) the operation of putting it in the trash should also delete all the outgoing permissions, or (c) the concept of trash doesn't apply to the role group, and it is always deleted immediately.

From discussion:

We probably want option (c), non-project groups should skip being trashed and be deleted immediately.


Subtasks 1 (0 open1 closed)

Task #18354: Review 18340-delete-role-filter-groupsResolvedLucas Di Pentima11/17/2021Actions
Actions #1

Updated by Peter Amstutz over 2 years ago

  • Description updated (diff)
Actions #2

Updated by Lucas Di Pentima over 2 years ago

  • Assigned To set to Lucas Di Pentima
Actions #3

Updated by Lucas Di Pentima over 2 years ago

  • Status changed from New to In Progress
Actions #4

Updated by Lucas Di Pentima over 2 years ago

Updates at 43d9cc591 - branch 18340-delete-role-filter-groups
Test run: developer-run-tests: #2802

  • Only use TrashableController.destroy on project groups.
  • Adds test.
Actions #5

Updated by Ward Vandewege over 2 years ago

Lucas Di Pentima wrote:

Updates at 43d9cc591 - branch 18340-delete-role-filter-groups
Test run: developer-run-tests: #2802

  • Only use TrashableController.destroy on project groups.
  • Adds test.

Just one question, why the removal of `protected` on line 354? Otherwise, LGTM, thanks!

Actions #6

Updated by Lucas Di Pentima over 2 years ago

Just for the record: the protected declaration was duplicated on that file.

Actions #7

Updated by Lucas Di Pentima over 2 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados-private:commit:arvados|2a13c742cdca6fbae46a9ce1c6ae044633d03ce3.

Actions #8

Updated by Peter Amstutz over 2 years ago

  • Release set to 45
Actions

Also available in: Atom PDF