Project

General

Profile

Actions
Copy link

Feature #18560

closed

Vocabulary picking improvements

Added by Peter Amstutz about 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Lucas Di Pentima
Category:
Workbench2
Target version:
2022-03-02 sprint
Story points:
-
Release:
Arvados 2.3.3
Release relationship:
Auto

Description

When setting properties, the value list can be very large. Suggested improvements:

  • In the full list, only show the first (preferred) synonym for each id
  • In the search, show the format "Preferred (synonym)" when the partial match is on the synonym
    • When there are multiple matches, it should only include a given id in the list once

Subtasks 1 (0 open — 1 closed)

Task #18644: Review 18560-wb2-vocabulary-pickingResolvedPeter Amstutz02/10/2022Actions

Related issues 1 (0 open — 1 closed)

Related to Arvados Epics - Idea #17454: Vocabulary checking of properties by API server/controllerResolved10/01/202103/31/2022Actions
Actions
Copy link
 #1

Updated by Peter Amstutz about 3 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Peter Amstutz about 3 years ago

  • Related to Idea #17454: Vocabulary checking of properties by API server/controller added
Actions
Copy link
 #3

Updated by Lucas Di Pentima almost 3 years ago

  • Target version set to 2022-02-02 sprint
Actions
Copy link
 #4

Updated by Peter Amstutz almost 3 years ago

  • Assigned To set to Lucas Di Pentima
Actions
Copy link
 #5

Updated by Peter Amstutz almost 3 years ago

  • Target version changed from 2022-02-02 sprint to 2022-02-16 sprint
Actions
Copy link
 #6

Updated by Lucas Di Pentima almost 3 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #7

Updated by Lucas Di Pentima almost 3 years ago

Updates at arvados-workbench2|1422847e - branch 18560-wb2-vocabulary-picking
Test run:

In the end, this was super easy to implement thanks to the feature-full component <Autocomplete> that already supports custom suggestion rendering.
I've added a couple of vocabulary query functions to retrieve the preferred terms for keys and values so that the fields use those to render the suggestion list.

For manual testing I recommend using arvbox because ce8i5 doesn't have any vocabulary configured.

Actions
Copy link
 #8

Updated by Lucas Di Pentima almost 3 years ago

Updates at arvados-workbench2|c72cb99d
Test run:

Fixes unrelated flaky test that failed on the previous run.

Actions
Copy link
 #9

Updated by Lucas Di Pentima almost 3 years ago

Updates at arvados-workbench2|1e771e80
Test run:

  • Refactors the vocabulary querying and suggestion rendering code so that only the synonyms that match the user's input are shown.
  • Updates tests.
Actions
Copy link
 #10

Updated by Lucas Di Pentima almost 3 years ago

  • Target version changed from 2022-02-16 sprint to 2022-03-02 sprint
Actions
Copy link
 #11

Updated by Peter Amstutz almost 3 years ago

This LGTM!

Actions
Copy link
 #12

Updated by Lucas Di Pentima almost 3 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link
 #13

Updated by Peter Amstutz almost 3 years ago

  • Release set to 49
Actions
Copy link

Also available in: Atom PDF