Project

General

Profile

Actions
Copy link

Feature #18656

closed

expression to dynamically request number of gpus

Added by Peter Amstutz almost 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Peter Amstutz
Category:
CWL
Target version:
2022-03-16 sprint
Story points:
-
Release:
Arvados 2.4.0
Release relationship:
Auto

Description

Can use a CWL expression for min and max GPUs.

Also need to re-introduce matching a specific list of hardware capabilities.

Subtasks 1 (0 open — 1 closed)

Task #18708: Review 18656-dynamic-gpu-reqResolvedPeter Amstutz03/01/2022Actions
Actions
Copy link
 #1

Updated by Peter Amstutz almost 3 years ago

  • Release set to 46
  • Description updated (diff)
Actions
Copy link
 #2

Updated by Peter Amstutz almost 3 years ago

  • Assigned To set to Peter Amstutz
Actions
Copy link
 #3

Updated by Peter Amstutz almost 3 years ago

  • Target version changed from 2022-02-16 sprint to 2022-03-02 sprint
Actions
Copy link
 #4

Updated by Peter Amstutz almost 3 years ago

  • Target version changed from 2022-03-02 sprint to 2022-03-16 sprint
Actions
Copy link
 #5

Updated by Peter Amstutz over 2 years ago

  • Target version changed from 2022-03-16 sprint to 2022-03-02 sprint
Actions
Copy link
 #6

Updated by Peter Amstutz over 2 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #7

Updated by Peter Amstutz over 2 years ago

18656-dynamic-gpu-req @ 926c011fb4f7a4d7722b88a19afed51c5d4bd1c4

  • Update cwltool version
  • Update extension
  • Update tests

developer-run-tests: #2937

Actions
Copy link
 #8

Updated by Peter Amstutz over 2 years ago

  • Target version changed from 2022-03-02 sprint to 2022-03-16 sprint
Actions
Copy link
 #9

Updated by Lucas Di Pentima over 2 years ago

Sorry for the delay! Just a couple of comments:

  • There's documentation referencing the old keywords that need updating.
  • At file sdk/cwl/arvados_cwl/arvcontainer.py L298: There's a resources.get("cudaDeviceCount", 1) call, but cudaDeviceCount doesn't exist without its Max/Min suffix, correct?
Actions
Copy link
 #10

Updated by Peter Amstutz over 2 years ago

Lucas Di Pentima wrote:

Sorry for the delay! Just a couple of comments:

  • There's documentation referencing the old keywords that need updating.

Good catch, fixed

  • At file sdk/cwl/arvados_cwl/arvcontainer.py L298: There's a resources.get("cudaDeviceCount", 1) call, but cudaDeviceCount doesn't exist without its Max/Min suffix, correct?

That's the "resources" object which has the actual resources that (will be) allocated, which is separate from the min/max request.

Right now Arvados is dumb about this and doesn't actually do anything useful with min/max ranges (it just requests the "min" value) but that is a different issue (#16316).

18656-cuda-expr-request @ 2dbbd648655ceb248dafff72e659c47277d11539

Actions
Copy link
 #11

Updated by Lucas Di Pentima over 2 years ago

LGTM, thanks!

Actions
Copy link
 #12

Updated by Peter Amstutz over 2 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link

Also available in: Atom PDF