Project

General

Profile

Actions

Feature #18692

open

Frozen projects workbench support

Added by Peter Amstutz 5 months ago. Updated 7 days ago.

Status:
In Progress
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
05/19/2022
Due date:
% Done:

0%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

In workbench 2, implement features described in #18390

write tests

From customer:

wb2 should perform client-side check if FreezeProjectRequiresDescription and FreezeProjectRequiresProperties are set.

Related: I also noticed a bug where if a collection is not writable, it still offers the "Remove" and "Rename" actions on the files, but they give an error if you use them. These should be hidden when the collection is read-only.


Subtasks 1 (1 open0 closed)

Task #18877: Review 18692-frozen-projects-workbench-supportIn ProgressDaniel Kutyła05/19/2022

Actions

Related issues

Related to Arvados - Feature #19146: Return can_manage and can_write alongside writable_byResolvedTom Clegg06/07/2022

Actions
Related to Arvados Epics - Story #18390: Frozen projectsIn Progress03/01/202207/31/2022

Actions
Blocked by Arvados - Feature #18691: Frozen project supportResolvedTom Clegg03/08/2022

Actions
Actions #1

Updated by Peter Amstutz 5 months ago

Actions #2

Updated by Peter Amstutz 5 months ago

  • Description updated (diff)
Actions #3

Updated by Peter Amstutz 5 months ago

  • Target version changed from 2022-03-02 sprint to 2022-03-16 sprint
Actions #4

Updated by Peter Amstutz 4 months ago

  • Target version changed from 2022-03-16 sprint to 2022-03-30 Sprint
Actions #5

Updated by Peter Amstutz 3 months ago

  • Target version changed from 2022-03-30 Sprint to 2022-04-13 Sprint
Actions #6

Updated by Peter Amstutz 3 months ago

  • Target version changed from 2022-04-13 Sprint to 2022-04-27 Sprint
Actions #7

Updated by Peter Amstutz 3 months ago

  • Status changed from New to In Progress
Actions #8

Updated by Peter Amstutz 2 months ago

  • Description updated (diff)
Actions #9

Updated by Peter Amstutz 2 months ago

  • Target version changed from 2022-04-27 Sprint to 2022-05-11 sprint
Actions #10

Updated by Peter Amstutz about 2 months ago

  • Target version changed from 2022-05-11 sprint to 2022-05-25 sprint
Actions #11

Updated by Daniel Kutyła about 2 months ago

  • Target version deleted (2022-05-25 sprint)

New version: https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/f1158a80eae96784f909ad496487f5604fe95329
Test run: developer-tests-workbench2: #686
Branch: 18692-frozen-projects-workbench-support

First implementation of frozen project support

Actions #12

Updated by Peter Amstutz about 1 month ago

  • Target version set to 2022-05-25 sprint
Actions #13

Updated by Peter Amstutz about 1 month ago

18692-frozen-projects-workbench-support @ arvados-workbench2|f1158a80eae96784f909ad496487f5604fe95329

describe.only('Frozen projects', () => {

Need to remove the '.only' before you merge it

Functional comments:

  • We called the feature "Frozen Projects" but the UI you added says "Lock project" and "Unlock project". Remind me if we discussed using a different word or did you just decide to change it?
  • There's an icon in the parent listing that indicates a project is frozen. However, when you are viewing the project itself, there is nothing to indicate it is frozen. Maybe add the icon next to the project name in the breadcrumbs?
  • If I try to freeze a project and it is rejected, I get a big red error snackbar with no formatting, which is very hard to read. Since validation errors are normal, either the error needs to be rendered better, or wb2 should perform its own a client-side check if FreezeProjectRequiresDescription and FreezeProjectRequiresProperties are set.
  • If the config key "API.UnfreezeProjectRequiresAdmin" is "false", regular users which have "can_manage" permission should be able to unfreeze a project.
  • The right-side info/details panel includes an "EDIT" button even when the project is frozen.
    • Attempting to edit and then save the project details results in an error and then the dialog is stuck in an infinite spinner (this basically locks up the app, it has to be reloaded).
    • This bug exists in the case of regular read-only project sharing as well (i.e. not frozen but still read-only for me, I see an edit button), it probably needs to check for write permission before rendering the edit button.
  • The context/action menu for frozen projects is missing "Share" and (for admins) "Add to public favorites" both of which are still valid operations.

It's clear several of these bugs are due to the fact that "writable_by" is empty and we don't indicate "managed_by" separately, so Workbench 2 doesn't have a good way of knowing the correct level of permission for a user looking at a frozen project. I've added #19146 to address this, so we might have to do that before some of the issues above can be fixed.

Actions #14

Updated by Peter Amstutz about 1 month ago

  • Related to Feature #19146: Return can_manage and can_write alongside writable_by added
Actions #15

Updated by Peter Amstutz about 1 month ago

  • Target version changed from 2022-05-25 sprint to 2022-06-08 sprint
Actions #16

Updated by Peter Amstutz 23 days ago

  • Description updated (diff)
Actions #17

Updated by Peter Amstutz 21 days ago

  • Target version changed from 2022-06-08 sprint to 2022-06-22 Sprint
Actions #18

Updated by Peter Amstutz 14 days ago

Actions #19

Updated by Peter Amstutz 7 days ago

  • Target version changed from 2022-06-22 Sprint to 2022-07-06
Actions

Also available in: Atom PDF