Project

General

Profile

Actions

Bug #18769

closed

Test & confirm no stale data or flickering during data table refreshes

Added by Peter Amstutz 12 months ago. Updated 11 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
02/17/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

#16951 describes how some tests that refresh the data table have been using workarounds due to stale data being present in the table.

Also, after implementation of #18207 I had these comments:

I played with ce8i5 cluster a bit.

  • Regular navigation works fine under "Projects" seems to mostly work fine. On click it clears the table, and loads the contents when ready as expected.

Here are the issues I'm seeing:

  • Hitting the refresh button on a project causes it to load twice resulting in a flicker (it clears the contents, the contents show up, then it clears them again, then the content shows up a 2nd time).
  • Navigating to a collection, then navigating back to the parent project or using the browser back button still seems to be showing old results as well as flickering:
    • It displays the project view with the old project contents
    • It clears the contents and shows the loading graphic
    • Then it shows the newly loaded contents
  • I went into "Shared with me" and clicked on a project. It showed the old contents, then the loading graphic, then the new contents.

Confirm that these issues are fixed, and remove workarounds from the Cypress tests.


Subtasks 2 (0 open2 closed)

Task #18780: Go through checks manuallyResolvedPeter Amstutz03/01/2022

Actions
Task #18781: Update testsClosedLucas Di Pentima02/17/2022

Actions

Related issues

Related to Arvados - Bug #16951: Can refresh listing when opening context menu, resulting in wrong item being operated on.ResolvedLucas Di Pentima01/18/2022

Actions
Related to Arvados - Bug #18207: Workbench2 is not clearing the project content when switchingResolvedDaniel KutyƂa11/04/2021

Actions
Related to Arvados Workbench 2 - Bug #18661: Refresh Button makes the project's listing to flicker while it loads 2 times in a rowResolvedLucas Di Pentima02/01/2022

Actions
Related to Arvados Workbench 2 - Bug #18787: Collection's file browser re-rendering issuesResolvedLucas Di Pentima05/31/2022

Actions
Actions #1

Updated by Peter Amstutz 12 months ago

  • Status changed from New to In Progress
Actions #2

Updated by Peter Amstutz 12 months ago

  • Related to Bug #16951: Can refresh listing when opening context menu, resulting in wrong item being operated on. added
Actions #3

Updated by Peter Amstutz 12 months ago

  • Description updated (diff)
Actions #4

Updated by Peter Amstutz 12 months ago

  • Related to Bug #18207: Workbench2 is not clearing the project content when switching added
Actions #5

Updated by Peter Amstutz 12 months ago

  • Related to Bug #18661: Refresh Button makes the project's listing to flicker while it loads 2 times in a row added
Actions #6

Updated by Peter Amstutz 12 months ago

  • Assigned To set to Lucas Di Pentima
Actions #7

Updated by Lucas Di Pentima 12 months ago

I haven't found any use of {force: true} on project listing cypress tests. I did found some on the collections tests so I branched off from #18315 changes and removed those at arvados-workbench2|58820ac (branch 18769-cypress-click-force-removal).

Did a test run (developer-tests-workbench2: #596 ) that failed with the expected errors, so they're still valid for the collection panel's file browser.

Actions #8

Updated by Peter Amstutz 12 months ago

What does {force: true} do?

Actions #9

Updated by Lucas Di Pentima 12 months ago

Disables "actionability checks" on the click() action: https://docs.cypress.io/guides/core-concepts/interacting-with-elements#Actionability -- so, using {force:true} is not recommended.

Actions #10

Updated by Lucas Di Pentima 12 months ago

Created #18787 to handle the file browser issue.

Actions #11

Updated by Lucas Di Pentima 12 months ago

  • Related to Bug #18787: Collection's file browser re-rendering issues added
Actions #12

Updated by Peter Amstutz 12 months ago

I went through the flickering issues I had seen before and they seem to all be fixed, thanks!

Actions #13

Updated by Peter Amstutz 12 months ago

Lucas Di Pentima wrote:

I haven't found any use of {force: true} on project listing cypress tests. I did found some on the collections tests so I branched off from #18315 changes and removed those at arvados-workbench2|58820ac (branch 18769-cypress-click-force-removal).

Did a test run (developer-tests-workbench2: #596 ) that failed with the expected errors, so they're still valid for the collection panel's file browser.

Does this pass without the file browser part, if so it can be merged?

Actions #14

Updated by Peter Amstutz 11 months ago

integration/favorites.spec.js:67: cy.get('[data-cy=collection-files-panel]').find('input[type=checkbox]').click({ force: true });

Actions #15

Updated by Lucas Di Pentima 11 months ago

Rebased branch 18769-cypress-click-force-removal with just the favorites test fixed at arvados-workbench2|05fb88d.
Test run: developer-tests-workbench2: #605

Actions #16

Updated by Lucas Di Pentima 11 months ago

Peter Amstutz wrote:

integration/favorites.spec.js:67: cy.get('[data-cy=collection-files-panel]').find('input[type=checkbox]').click({ force: true });

Ok, even though the .click() is made on the file browser, it seems that wasn't needed. But if you prefer to be on the safe side and avoid a flaky test I think we could just ignore this branch.

Actions #17

Updated by Lucas Di Pentima 11 months ago

  • Target version changed from 2022-03-02 sprint to 2022-03-16 sprint
Actions #18

Updated by Peter Amstutz 11 months ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF