Project

General

Profile

Actions

Bug #18787

closed

Collection's file browser re-rendering issues

Added by Lucas Di Pentima 5 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Start date:
05/31/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

As part of a general check of the app's UI refreshing issues in #18769 we tried removing the use of {force: true} on cypress tests' click() actions (see branch 18769-cypress-click-force-removal - arvados-workbench2|58820ac) and several tests started to fail with the following errors:

  • CypressError: Timed out retrying after 4050ms: `cy.click()` failed because this element is detached from the DOM.
  • CypressError: Timed out retrying after 4050ms: `cy.rightclick()` failed because this element is detached from the DOM.

This is probably a sign that there's some unnecessary re-rendering happening on the file browser, making the Cypress tests select an element that's immediately replaced by another similar one.


Subtasks 1 (0 open1 closed)

Arvados - Task #18819: Review 18787-file-browser-rerendering-fixResolvedStephen Smith05/31/2022

Actions

Related issues

Related to Arvados - Bug #18769: Test & confirm no stale data or flickering during data table refreshesResolvedLucas Di Pentima02/17/2022

Actions
Actions #1

Updated by Lucas Di Pentima 5 months ago

  • Related to Bug #18769: Test & confirm no stale data or flickering during data table refreshes added
Actions #2

Updated by Lucas Di Pentima 4 months ago

  • Assigned To set to Lucas Di Pentima
  • Category deleted (Workbench2)
Actions #3

Updated by Lucas Di Pentima 4 months ago

  • Status changed from New to In Progress
Actions #4

Updated by Lucas Di Pentima 4 months ago

  • Target version changed from 2022-03-16 sprint to 2022-03-30 Sprint
Actions #5

Updated by Peter Amstutz 3 months ago

  • Target version changed from 2022-03-30 Sprint to 2022-04-13 Sprint
Actions #6

Updated by Lucas Di Pentima 3 months ago

  • Target version changed from 2022-04-13 Sprint to 2022-04-27 Sprint
Actions #7

Updated by Peter Amstutz 2 months ago

  • Target version changed from 2022-04-27 Sprint to 2022-05-25 sprint
Actions #8

Updated by Peter Amstutz about 2 months ago

I was using wb2 recently and there was a noticeable flicker when visiting the collection panel, the file browser appeared, blanked out, then appeared again.

Actions #9

Updated by Lucas Di Pentima about 2 months ago

Peter Amstutz wrote:

I was using wb2 recently and there was a noticeable flicker when visiting the collection panel, the file browser appeared, blanked out, then appeared again.

Hi Peter. I have a partial fix on the re-rendering related to the collection's panel loading process. The left & right browser sub-panels are handled differently, and I still get to see why the right side keeps re-rendering many times on load.
Was this collection being modified at the time you were seeing the flickering? If we also have flickering issues on collection updates, it's an excellent time to include them in this ticket.

Actions #10

Updated by Lucas Di Pentima about 1 month ago

  • Target version changed from 2022-05-25 sprint to 2022-06-08 sprint
Actions #11

Updated by Lucas Di Pentima about 1 month ago

Updates at arvados-workbench2|f0f1a84 - branch 18787-file-browser-rerendering-fix
Test run: developer-tests-workbench2: #725

This branch removes leftover code from the old file browser from several places and avoids forcing re-renderings because of duplicated action dispatches.
There're still improvement opportunities, especially on the browser's state handling code, which seems overly complicated, and I suspect cross-dependencies are forcing unneeded renderings.
The current improvements should fix the flaky tests that we were seeing. I believe they interact with collections so that they don't exercise the browser's "left side" listing that appears when accessing a subdirectory.

Actions #12

Updated by Stephen Smith about 1 month ago

LGTM!

Actions #13

Updated by Lucas Di Pentima about 1 month ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF