https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422022-03-10T17:13:18ZArvadosArvados Workbench 2 - Bug #18834: [Workbench2] uploading a file into a subdirectory of a collection does not work, file always goes into the root of the collectionhttps://dev.arvados.org/issues/18834?journal_id=1015872022-03-10T17:13:18ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2022-03-30 Sprint</i> to <i>2022-03-16 sprint</i></li><li><strong>Assigned To</strong> set to <i>Daniel Kutyła</i></li></ul> Arvados Workbench 2 - Bug #18834: [Workbench2] uploading a file into a subdirectory of a collection does not work, file always goes into the root of the collectionhttps://dev.arvados.org/issues/18834?journal_id=1018002022-03-16T15:06:07ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2022-03-16 sprint</i> to <i>2022-03-30 Sprint</i></li></ul> Arvados Workbench 2 - Bug #18834: [Workbench2] uploading a file into a subdirectory of a collection does not work, file always goes into the root of the collectionhttps://dev.arvados.org/issues/18834?journal_id=1019212022-03-18T14:20:11ZDaniel Kutyła
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados Workbench 2 - Bug #18834: [Workbench2] uploading a file into a subdirectory of a collection does not work, file always goes into the root of the collectionhttps://dev.arvados.org/issues/18834?journal_id=1021952022-03-28T07:41:15ZDaniel Kutyła
<ul></ul><p>New version: <a class="external" href="https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/992852b9506bd3092bd052c681afca966478f88b">https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/992852b9506bd3092bd052c681afca966478f88b</a><br />Test run: developer-tests-workbench2: #624 <br />Branch: 18834-uploading-a-file-into-a-subdirectory-of-a-collection-does-not-work</p>
<p>Fixed upload to a subdirectory</p> Arvados Workbench 2 - Bug #18834: [Workbench2] uploading a file into a subdirectory of a collection does not work, file always goes into the root of the collectionhttps://dev.arvados.org/issues/18834?journal_id=1021962022-03-28T08:25:18ZDaniel Kutyła
<ul></ul><p>New version: <a class="external" href="https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/44d370d6e0e9e91dbc579e7d990667d52ad67b17">https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/44d370d6e0e9e91dbc579e7d990667d52ad67b17</a><br />Test run: developer-tests-workbench2: <a class="external" href="https://ci.arvados.org/job/developer-tests-workbench2/626"<a href="https://ci.arvados.org/job/developer-tests-workbench2/626/">developer-tests-workbench2: #626 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=626" alt="" /></a></a><br />Branch: 18834-uploading-a-file-into-a-subdirectory-of-a-collection-does-not-work</p>
<p>Fixed failing unit tests</p> Arvados Workbench 2 - Bug #18834: [Workbench2] uploading a file into a subdirectory of a collection does not work, file always goes into the root of the collectionhttps://dev.arvados.org/issues/18834?journal_id=1023002022-03-30T15:12:51ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2022-03-30 Sprint</i> to <i>2022-04-13 Sprint</i></li></ul> Arvados Workbench 2 - Bug #18834: [Workbench2] uploading a file into a subdirectory of a collection does not work, file always goes into the root of the collectionhttps://dev.arvados.org/issues/18834?journal_id=1023672022-03-31T13:43:35ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Reviewing <a class="changeset" title="18834: Re-enabled check Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors...." href="https://dev.arvados.org/projects/arvados-workbench-2/repository/arvados-workbench2/revisions/c8a07de05867fe2e959eb0063a674a4f026f5b76">arvados-workbench2|c8a07de</a> - <a class="external" href="https://ci.arvados.org/job/developer-tests-workbench2/631/"<a href="https://ci.arvados.org/job/developer-tests-workbench2/631/">developer-tests-workbench2: #631 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=631" alt="" /></a></a></p>
<ul>
<li>At file <code>collection-service.ts</code>:
<ul>
<li>Methods <code>uploadFiles()/uploadFile()</code>: Instead of having a <code>targetLocation</code> param that completely overrides both <code>collectionUuid</code> and <code>file.name</code> for the final <code>fileURL</code> construction, I think it would be more dev-friendly to add a param called something like <code>destPath</code> with <code>'/'</code> as a default value, so that it's used as another component of the fileURL building code. What do you think? Callers that don't specify it will get their uploads to go to the collection's root dir, and others will be able to specify where exactly files should be uploaded, making the code more readable.</li>
</ul>
</li>
<li>Could you add some unit testing on <code>uploadFiles()/uploadFile()</code>? We should be trying to improve the testing coverage whenever we can.</li>
<li>What's the fix at <a class="changeset" title="18834: Fixed failing tests Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contracto..." href="https://dev.arvados.org/projects/arvados-workbench-2/repository/arvados-workbench2/revisions/44d370d6e0e9e91dbc579e7d990667d52ad67b17">arvados-workbench2|44d370d</a> about? Seems unrelated to this branch.</li>
<li>The new cypress test code doesn't seem to confirm that the file was really uploaded to the correct "<code>subdir/</code>", it just confirms that it was uploaded. Could you add an assertion on that too? One easy way to do it is to re-request the collection's record and check its manifest data.</li>
</ul> Arvados Workbench 2 - Bug #18834: [Workbench2] uploading a file into a subdirectory of a collection does not work, file always goes into the root of the collectionhttps://dev.arvados.org/issues/18834?journal_id=1024822022-04-05T15:13:03ZDaniel Kutyła
<ul></ul><p>New version: <a class="external" href="https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/14b107de3fe4c29f4a37f1958bad99e2b82d2b24">https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/14b107de3fe4c29f4a37f1958bad99e2b82d2b24</a><br />Test run: developer-tests-workbench2: developer-tests-workbench2: #644<br />Branch: 18834-uploading-a-file-into-a-subdirectory-of-a-collection-does-not-work</p>
<p>Added unit tests, made cypress test more strict</p> Arvados Workbench 2 - Bug #18834: [Workbench2] uploading a file into a subdirectory of a collection does not work, file always goes into the root of the collectionhttps://dev.arvados.org/issues/18834?journal_id=1024842022-04-05T15:50:48ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Just one observation:</p>
<ul>
<li>One of the new unit tests reveals that the code is issuing an upload request with double-slashes (file <code>src/services/collection-service/collection-service.test.ts:L125</code>). Could you fix the code (and update the test assertion) so that it doesn't do that?</li>
</ul>
<p>Other than that, LGTM.</p> Arvados Workbench 2 - Bug #18834: [Workbench2] uploading a file into a subdirectory of a collection does not work, file always goes into the root of the collectionhttps://dev.arvados.org/issues/18834?journal_id=1025342022-04-06T20:26:44ZDaniel Kutyła
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset <a class="changeset" title="Merge branch '18834-uploading-a-file-into-a-subdirectory-of-a-collection-does-not-work' into main..." href="https://dev.arvados.org/projects/arvados-workbench-2/repository/arvados-workbench2/revisions/8d374520f28b507e8934d57be46374044fb93e2f">arvados-workbench2|8d374520f28b507e8934d57be46374044fb93e2f</a>.</p> Arvados Workbench 2 - Bug #18834: [Workbench2] uploading a file into a subdirectory of a collection does not work, file always goes into the root of the collectionhttps://dev.arvados.org/issues/18834?journal_id=1039902022-05-27T16:01:18ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>51</i></li></ul>