Project

General

Profile

Actions

Story #18848

closed

Update to yarn 3

Added by Tom Clegg 4 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Start date:
03/15/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

Advice from yarn devs about slow builds seems to be "v2 is faster, wontfix v1"

https://github.com/yarnpkg/yarn/issues/7921


Subtasks 1 (0 open1 closed)

Arvados - Task #18868: review 18848-upgrade-yarn3ResolvedTom Clegg03/15/2022

Actions
Actions #2

Updated by Tom Clegg 4 months ago

  • Target version changed from 2022-03-16 sprint to 2022-03-30 Sprint
Actions #3

Updated by Ward Vandewege 4 months ago

I pushed two commits to this branch: one to fix the `yarn build` call used in the `build` make target: `yarn build` is now picky about undefined variables. The other commit makes the Dockerfile used for wb2 package building and testing automatically pick the correct Go version, not some hardcoded one.

I've tested that the generated packages still work.

ebb5bf6fc93912af4013cb74b751e877c292eee7

developer-tests-workbench2: #616

Hmm, spec.js failure, maybe transient? Re-running at

developer-tests-workbench2: #617

More of these failures, re-running once more:

developer-tests-workbench2: #618

Out of curiosity I measured the timing of `make packages-in-docker` for main vs this branch (excluding the time needed to build the docker image):

Main (but, with a package build image that has Go 1.17.1, we require 1.17 now):

time ARVADOS_DIRECTORY=/tmp/arvados make packages-in-docker 

...
real    1m27.611s
user    0m0.139s
sys    0m0.073s

The 18848-upgrade-yarn3 branch:

time ARVADOS_DIRECTORY=/tmp/arvados make packages-in-docker
...
real    1m28.103s
user    0m0.161s
sys    0m0.067s

With those changes LGTM, assuming we can get the tests to pass!

Judging by https://ci.arvados.org/view/Workbench2%20build%20pipeline/job/workbench2-run-tests/, the occasional test failures in spec.js are not new, so I guess we just got unlucky here.

Actions #4

Updated by Tom Clegg 4 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF