Update to yarn 3
Advice from yarn devs about slow builds seems to be "v2 is faster, wontfix v1"
Updated by Ward Vandewege 4 months ago
I pushed two commits to this branch: one to fix the `yarn build` call used in the `build` make target: `yarn build` is now picky about undefined variables. The other commit makes the Dockerfile used for wb2 package building and testing automatically pick the correct Go version, not some hardcoded one.
I've tested that the generated packages still work.
Hmm, spec.js failure, maybe transient? Re-running at
More of these failures, re-running once more:
Out of curiosity I measured the timing of `make packages-in-docker` for main vs this branch (excluding the time needed to build the docker image):
Main (but, with a package build image that has Go 1.17.1, we require 1.17 now):
time ARVADOS_DIRECTORY=/tmp/arvados make packages-in-docker ... real 1m27.611s user 0m0.139s sys 0m0.073s
The 18848-upgrade-yarn3 branch:
time ARVADOS_DIRECTORY=/tmp/arvados make packages-in-docker ... real 1m28.103s user 0m0.161s sys 0m0.067s
With those changes LGTM, assuming we can get the tests to pass!
Judging by https://ci.arvados.org/view/Workbench2%20build%20pipeline/job/workbench2-run-tests/, the occasional test failures in spec.js are not new, so I guess we just got unlucky here.
- % Done changed from 0 to 100
- Status changed from In Progress to Resolved
Applied in changeset arvados-workbench2|ac317fdfc6cc1bfdee257580a03a6054edac05a2.