Project

General

Profile

Actions

Feature #18857

closed

improve Redmine renderer for links to jenkins

Added by Peter Amstutz 11 months ago. Updated 11 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Redmine
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Story points:
-

Description

1. Job URL can have /view/<view name> in front of them, currently it doesn't recognize it, for example, these are links to the same job:

build-and-publish-rc-packages: #131

build-and-publish-rc-packages: #131

2. You can't tell what job is being linked to. It would be helpful if it rendered as "<job name> #<job number> <status badge>"

Actions #1

Updated by Peter Amstutz 11 months ago

  • Description updated (diff)
Actions #2

Updated by Ward Vandewege 11 months ago

  • Assigned To set to Ward Vandewege
  • Status changed from New to In Progress
Actions #3

Updated by Ward Vandewege 11 months ago

  • Status changed from In Progress to Resolved

1. Job URL can have /view/<view name> in front of them, currently it doesn't recognize it, for example, these are links to the same job:

That format was already supported, actually, but it didn't match because of the % in the name of the view. I've added that character to the whitelist, and now both links work:

build-and-publish-rc-packages: #131

build-and-publish-rc-packages: #131

2. You can't tell what job is being linked to. It would be helpful if it rendered as "<job name> #<job number> <status badge>"

Good idea! Done.

Actions #4

Updated by Peter Amstutz 11 months ago

If you go through this page, there's a couple patterns it still doesn't recognize https://dev.arvados.org/issues/18733

2.3-run-tests: #22

build-java-sdk: #40

Actions #5

Updated by Peter Amstutz 11 months ago

  • Target version changed from 2022-03-30 Sprint to 2022-03-16 sprint
  • Status changed from Resolved to Feedback
Actions #6

Updated by Ward Vandewege 11 months ago

  • Status changed from Feedback to Resolved

Peter Amstutz wrote:

If you go through this page, there's a couple patterns it still doesn't recognize https://dev.arvados.org/issues/18733

2.3-run-tests: #22

build-java-sdk: #40

Oh, right, I've tweaked the regexp to be much more tolerant of the characters used in job and view names, and to handle trailing slashes appropriately.

Actions

Also available in: Atom PDF