Project

General

Profile

Actions
Copy link

Support #18862

closed

remove replay_job_log rake task

Added by Ward Vandewege almost 3 years ago. Updated 10 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Tom Clegg
Category:
API
Target version:
Development 2024-01-03 sprint
Due date:
Story points:
-
Release:
Arvados 3.0
Release relationship:
Auto

Description

As identified in https://dev.arvados.org/issues/18763#note-5, the "replay_job_log" task and the associated "lib/simulate_job_log.rb" file in the API server directory are only used by a workbench1 test. Remove them once workbench1 is gone from the codebase.

Subtasks 1 (0 open — 1 closed)

Task #21234: Review 18862-replay-job-log-taskResolvedLucas Di Pentima11/30/2023Actions

Related issues 1 (0 open — 1 closed)

Related to Arvados Epics - Idea #17001: Arvados uses WB2 by defaultResolvedActions
Actions
Copy link
 #2

Updated by Ward Vandewege almost 3 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Peter Amstutz about 2 years ago

  • Release set to 60
Actions
Copy link
 #4

Updated by Peter Amstutz over 1 year ago

  • Release deleted (60)
  • Target version set to Development 2023-10-11 sprint
Actions
Copy link
 #5

Updated by Peter Amstutz over 1 year ago

  • Related to Idea #17001: Arvados uses WB2 by default added
Actions
Copy link
 #6

Updated by Peter Amstutz over 1 year ago

  • Target version changed from Development 2023-10-11 sprint to Development 2023-10-25 sprint
Actions
Copy link
 #7

Updated by Peter Amstutz over 1 year ago

  • Category set to API
  • Subject changed from [api] remove replay_job_log rake task to remove replay_job_log rake task
  • Tracker changed from Bug to Feature
Actions
Copy link
 #8

Updated by Peter Amstutz over 1 year ago

  • Tracker changed from Feature to Support
Actions
Copy link
 #9

Updated by Peter Amstutz over 1 year ago

  • Target version changed from Development 2023-10-25 sprint to Development 2023-11-08 sprint
Actions
Copy link
 #10

Updated by Peter Amstutz over 1 year ago

  • Target version changed from Development 2023-11-08 sprint to Development 2023-11-29 sprint
Actions
Copy link
 #11

Updated by Peter Amstutz over 1 year ago

  • Target version changed from Development 2023-11-29 sprint to Future
Actions
Copy link
 #12

Updated by Peter Amstutz over 1 year ago

  • Target version changed from Future to Development 2024-01-03 sprint
Actions
Copy link
 #13

Updated by Peter Amstutz over 1 year ago

  • Target version changed from Development 2024-01-03 sprint to Development 2023-11-29 sprint
Actions
Copy link
 #14

Updated by Peter Amstutz over 1 year ago

  • Assigned To set to Tom Clegg
Actions
Copy link
 #15

Updated by Tom Clegg about 1 year ago

  • Target version changed from Development 2023-11-29 sprint to Development 2024-01-03 sprint
Actions
Copy link
 #16

Updated by Tom Clegg about 1 year ago

  • Status changed from New to In Progress
Actions
Copy link
 #17

Updated by Lucas Di Pentima about 1 year ago

Some comments:

  • There's a lib/dispatchcloud test failing. Not related to this branch but I've seen it fail in other reviews. Something that changed recently makes it fail sometimes? Re-run here: developer-run-tests-remainder: #4134
  • From reading the ticket's description, it seems that services/api/lib/simulate_job_log.rb also needs to be removed.
Actions
Copy link
 #18

Updated by Tom Clegg about 1 year ago

Oops. Removed simulate_job_log.rb as well.

18862-replay-job-log-task @ 36ff46b93e0fde77f049140f3159f89940fc0d4e -- developer-run-tests: #3933

I'll look at the dispatchcloud thing as well but I don't suppose it should block this merge.

Actions
Copy link
 #19

Updated by Lucas Di Pentima about 1 year ago

LGTM, thanks.

Actions
Copy link
 #20

Updated by Tom Clegg about 1 year ago

  • Status changed from In Progress to Resolved
Actions
Copy link
 #21

Updated by Peter Amstutz 10 months ago

  • Release set to 70
Actions
Copy link

Also available in: Atom PDF