Project

General

Profile

Actions

Support #18862

closed

remove replay_job_log rake task

Added by Ward Vandewege about 2 years ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
API
Due date:
Story points:
-

Description

As identified in https://dev.arvados.org/issues/18763#note-5, the "replay_job_log" task and the associated "lib/simulate_job_log.rb" file in the API server directory are only used by a workbench1 test. Remove them once workbench1 is gone from the codebase.


Subtasks 1 (0 open1 closed)

Task #21234: Review 18862-replay-job-log-taskResolvedLucas Di Pentima11/30/2023Actions

Related issues

Related to Arvados Epics - Idea #17001: Arvados uses WB2 by defaultNewActions
Actions #2

Updated by Ward Vandewege about 2 years ago

  • Description updated (diff)
Actions #3

Updated by Peter Amstutz about 1 year ago

  • Release set to 60
Actions #4

Updated by Peter Amstutz 6 months ago

  • Release deleted (60)
  • Target version set to Development 2023-10-11 sprint
Actions #5

Updated by Peter Amstutz 6 months ago

  • Related to Idea #17001: Arvados uses WB2 by default added
Actions #6

Updated by Peter Amstutz 6 months ago

  • Target version changed from Development 2023-10-11 sprint to Development 2023-10-25 sprint
Actions #7

Updated by Peter Amstutz 6 months ago

  • Category set to API
  • Subject changed from [api] remove replay_job_log rake task to remove replay_job_log rake task
  • Tracker changed from Bug to Feature
Actions #8

Updated by Peter Amstutz 6 months ago

  • Tracker changed from Feature to Support
Actions #9

Updated by Peter Amstutz 6 months ago

  • Target version changed from Development 2023-10-25 sprint to Development 2023-11-08 sprint
Actions #10

Updated by Peter Amstutz 5 months ago

  • Target version changed from Development 2023-11-08 sprint to Development 2023-11-29 sprint
Actions #11

Updated by Peter Amstutz 5 months ago

  • Target version changed from Development 2023-11-29 sprint to Future
Actions #12

Updated by Peter Amstutz 5 months ago

  • Target version changed from Future to Development 2024-01-03 sprint
Actions #13

Updated by Peter Amstutz 5 months ago

  • Target version changed from Development 2024-01-03 sprint to Development 2023-11-29 sprint
Actions #14

Updated by Peter Amstutz 5 months ago

  • Assigned To set to Tom Clegg
Actions #15

Updated by Tom Clegg 4 months ago

  • Target version changed from Development 2023-11-29 sprint to Development 2024-01-03 sprint
Actions #16

Updated by Tom Clegg 4 months ago

  • Status changed from New to In Progress
Actions #17

Updated by Lucas Di Pentima 4 months ago

Some comments:

  • There's a lib/dispatchcloud test failing. Not related to this branch but I've seen it fail in other reviews. Something that changed recently makes it fail sometimes? Re-run here: developer-run-tests-remainder: #4134
  • From reading the ticket's description, it seems that services/api/lib/simulate_job_log.rb also needs to be removed.
Actions #18

Updated by Tom Clegg 4 months ago

Oops. Removed simulate_job_log.rb as well.

18862-replay-job-log-task @ 36ff46b93e0fde77f049140f3159f89940fc0d4e -- developer-run-tests: #3933

I'll look at the dispatchcloud thing as well but I don't suppose it should block this merge.

Actions #19

Updated by Lucas Di Pentima 4 months ago

LGTM, thanks.

Actions #20

Updated by Tom Clegg 4 months ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF