Project

General

Profile

Actions

Bug #18866

closed

Property editor misbehavior on keys without labels

Added by Lucas Di Pentima 11 months ago. Updated 11 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Start date:
03/15/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

When there's a key definition like this one:

    "automation": {
      "labels": [],
      "strict": true,
      "values": {
        "results": {
          "labels": []
        },
        "upload": {
          "labels": []
        }
      }
    }

The property editor correctly list the "automation" key id on the key dropdown list. When selected, the value dropdown list doesn't list the "upload" & "results" ids and allows the user to input any text.

This doesn't happen if the key has some label in its definition:

    "automation": {
      "labels": [{"label":"Automation metadata"}],
      "strict": true,
      "values": {
        "results": {
          "labels": []
        },
        "upload": {
          "labels": []
        }
      }
    }

Subtasks 1 (0 open1 closed)

Task #18869: Review 18866-property-editor-bugfixResolvedWard Vandewege03/15/2022

Actions
Actions #1

Updated by Lucas Di Pentima 11 months ago

  • Status changed from New to In Progress
Actions #2

Updated by Lucas Di Pentima 11 months ago

Updates at arvados-workbench2|31965b61 - branch 18866-property-editor-bugfix - developer-tests-workbench2: #613

  • Fixes key/value lookup functions so that they also treat IDs as a valid search term, useful for cases where there's a key or value without labels.
  • Adds test cases.
Actions #3

Updated by Peter Amstutz 11 months ago

  • Release set to 46
Actions #4

Updated by Peter Amstutz 11 months ago

  • Target version changed from 2022-03-16 sprint to 2022-03-30 Sprint
Actions #5

Updated by Ward Vandewege 11 months ago

Lucas Di Pentima wrote:

Updates at arvados-workbench2|31965b61 - branch 18866-property-editor-bugfix - developer-tests-workbench2: #613

  • Fixes key/value lookup functions so that they also treat IDs as a valid search term, useful for cases where there's a key or value without labels.
  • Adds test cases.

Thank you, I tested it, and it works. LGTM.

Actions #6

Updated by Lucas Di Pentima 11 months ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF