Project

General

Profile

Actions

Feature #18881

closed

Display container runtime_status

Added by Peter Amstutz 4 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
04/08/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

runtime status can have "warning" and "error" fields.

If there's an "error" the container should be displayed as in a "failing" state.

When the process appears in the project list or "all projects" or "child processes" it should show an icon when it is in "failing" state.

On the process main panel it should show all the warnings and errors.


Files


Subtasks 1 (0 open1 closed)

Task #18884: Review 18881-process-runtime-statusResolvedWard Vandewege04/08/2022

Actions

Related issues

Related to Arvados Epics - Story #16945: WB2 Workflows / containers feature parityIn Progress08/01/202107/31/2022

Actions
Actions #1

Updated by Peter Amstutz 3 months ago

  • Related to Story #16945: WB2 Workflows / containers feature parity added
Actions #2

Updated by Peter Amstutz 3 months ago

  • Description updated (diff)
Actions #3

Updated by Lucas Di Pentima 3 months ago

  • Status changed from New to In Progress
Actions #4

Updated by Peter Amstutz 3 months ago

  • Target version changed from 2022-03-30 Sprint to 2022-04-13 Sprint
Actions #5

Updated by Lucas Di Pentima 3 months ago

Updates at arvados-workbench2|a5750c2 - branch 18881-process-runtime-status
Test run: developer-tests-workbench2: #649

  • Adds "Failing" and "Warning" as new process states that depend not only on the container's state but also the runtime status data.
  • Fixes status indications by conforming on how workbech1 renders them.
  • Adds runtime status indications to the process info panel.
  • Adds tests.
Actions #6

Updated by Lucas Di Pentima 3 months ago

Updates at arvados-workbench2|078bedef - developer-tests-workbench2: #652

  • Adds workarounds on unrelated flaky tests.
Actions #7

Updated by Ward Vandewege 3 months ago

Lucas Di Pentima wrote:

Updates at arvados-workbench2|078bedef - developer-tests-workbench2: #652

  • Adds workarounds on unrelated flaky tests.

This looks great! My only comment is that it would be nice to use the same colorful button-style status fields in the process list view (e.g. "All Processes"), rather than the current colored text there, some of which can be hard to read (e.g. 'Queued' in light gray on a white background). I think it would also be nicer aesthetically.

LGTM otherwise.

Actions #8

Updated by Lucas Di Pentima 3 months ago

Updates at arvados-workbench2|18425d0d - developer-tests-workbench2: #653

  • Makes the process status indicator to be consistent on listings with the style that's used on the process info panel.
  • Updates tests.
Actions #9

Updated by Ward Vandewege 3 months ago

Lucas Di Pentima wrote:

Updates at arvados-workbench2|18425d0d - developer-tests-workbench2: #653

  • Makes the process status indicator to be consistent on listings with the style that's used on the process info panel.
  • Updates tests.

Loving the buttons in the data tables! But I guess something went wrong in the project listing, cf.

Actions #12

Updated by Ward Vandewege 3 months ago

Lucas Di Pentima wrote:

Whoops! fixed at arvados-workbench2|03578e71 - developer-tests-workbench2: #654

Perfect, thanks! LGTM.

Actions #13

Updated by Lucas Di Pentima 3 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved
Actions #14

Updated by Lucas Di Pentima 3 months ago

Updates at arvados-workbench2|fe2fcf6b - branch 18881-failing-state-color-fix
Test run: developer-tests-workbench2: #667

  • Fixes the "Failing" state's color, setting ip from red to orange.
  • Updates unit test.
Actions #15

Updated by Peter Amstutz about 1 month ago

  • Release set to 51
Actions

Also available in: Atom PDF