Project

General

Profile

Actions

Feature #18896

closed

[controller] should log the uuids of all tokens for each request

Added by Ward Vandewege 3 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
03/26/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Subtasks 1 (0 open1 closed)

Task #18934: review 18896-controller-logs-tokenUUIDsResolvedWard Vandewege03/26/2022

Actions

Related issues

Related to Arvados - Bug #18887: [federation] wb1 fiddlesticks in login federationResolvedWard Vandewege03/25/2022

Actions
Related to Arvados - Story #17464: Logging and restricting downloads in keep-web and keepproxyResolvedPeter Amstutz06/15/2021

Actions
Related to Arvados - Feature #18944: [controller] should log the user uuid used for the requestNew

Actions
Related to Arvados - Feature #18897: [go services] should log the uuid of the token used for each request (and if available, the uuid of the associated user)New

Actions
Actions #1

Updated by Ward Vandewege 3 months ago

  • Status changed from New to In Progress
Actions #2

Updated by Ward Vandewege 3 months ago

  • Status changed from In Progress to New
  • Subject changed from [controller] should log the uuid of the user and the token for each request. to [controller] should log the uuid of the user and the uuid of the token for each request.
Actions #3

Updated by Ward Vandewege 3 months ago

  • Related to Bug #18887: [federation] wb1 fiddlesticks in login federation added
Actions #4

Updated by Ward Vandewege 3 months ago

  • Related to Story #17464: Logging and restricting downloads in keep-web and keepproxy added
Actions #5

Updated by Ward Vandewege 3 months ago

  • Release set to 46
  • Target version changed from 2022-04-13 Sprint to 2022-03-30 Sprint
  • Assigned To set to Ward Vandewege
  • Status changed from New to In Progress
Actions #6

Updated by Tom Clegg 3 months ago

This LGTM, thanks. Just a style nitpick, the "if ok"s should probably be "if !ok { return early }" instead of a pyramid. Could do this:

m, _ := ctx.Value(&mutexContextKey).(sync.Mutex)
c, _ := ctx.Value(&responseLogFieldsContextKey).(logrus.Fields)
if m == nil || c == nil {
  return
}
// normal case
Actions #7

Updated by Ward Vandewege 3 months ago

Tom Clegg wrote:

This LGTM, thanks. Just a style nitpick, the "if ok"s should probably be "if !ok { return early }" instead of a pyramid. Could do this:

[...]

Thanks, done, and thanks for the test!

developer-run-tests: #2998

Actions #8

Updated by Ward Vandewege 3 months ago

  • Subject changed from [controller] should log the uuid of the user and the uuid of the token for each request. to [controller] should log the uuids of all tokens for each request
Actions #9

Updated by Ward Vandewege 3 months ago

  • Related to Feature #18944: [controller] should log the user uuid used for the request added
Actions #10

Updated by Ward Vandewege 3 months ago

  • Status changed from In Progress to Resolved
Actions #11

Updated by Ward Vandewege 3 months ago

  • Related to Feature #18897: [go services] should log the uuid of the token used for each request (and if available, the uuid of the associated user) added
Actions

Also available in: Atom PDF