https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422022-03-21T20:04:47ZArvadosArvados - Feature #18896: [controller] should log the uuids of all tokens for each requesthttps://dev.arvados.org/issues/18896?journal_id=1019752022-03-21T20:04:47ZWard Vandewegeward@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Feature #18896: [controller] should log the uuids of all tokens for each requesthttps://dev.arvados.org/issues/18896?journal_id=1019762022-03-21T20:06:47ZWard Vandewegeward@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>New</i></li><li><strong>Subject</strong> changed from <i>[controller] should log the uuid of the user and the token for each request.</i> to <i>[controller] should log the uuid of the user and the uuid of the token for each request.</i></li></ul> Arvados - Feature #18896: [controller] should log the uuids of all tokens for each requesthttps://dev.arvados.org/issues/18896?journal_id=1019782022-03-21T20:08:15ZWard Vandewegeward@curii.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-3 priority-4 priority-default closed parent" href="/issues/18887">Bug #18887</a>: [federation] wb1 fiddlesticks in login federation</i> added</li></ul> Arvados - Feature #18896: [controller] should log the uuids of all tokens for each requesthttps://dev.arvados.org/issues/18896?journal_id=1020302022-03-23T14:26:41ZWard Vandewegeward@curii.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-6 status-3 priority-4 priority-default closed parent" href="/issues/17464">Idea #17464</a>: Logging and restricting downloads in keep-web and keepproxy</i> added</li></ul> Arvados - Feature #18896: [controller] should log the uuids of all tokens for each requesthttps://dev.arvados.org/issues/18896?journal_id=1021652022-03-25T12:00:34ZWard Vandewegeward@curii.com
<ul><li><strong>Release</strong> set to <i>46</i></li><li><strong>Target version</strong> changed from <i>2022-04-13 Sprint</i> to <i>2022-03-30 Sprint</i></li><li><strong>Assigned To</strong> set to <i>Ward Vandewege</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul><p><a class="changeset" title="18896: add locking. Also handle v1 tokens shorter than 5 characters. Arvados-DCO-1.1-Signed-off-..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/8f0f3b495d0c715cc57d0d384bc5839acf9ece3f">8f0f3b495d0c715cc57d0d384bc5839acf9ece3f</a> on branch 18896-controller-logs-tokenUUIDs adds token UUID logging.</p>
<p><a class="external" href="https://ci.arvados.org/job/developer-run-tests-remainder/3128/"<a href="https://ci.arvados.org/job/developer-run-tests-remainder/3128/">developer-run-tests-remainder: #3128 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests-remainder&build=3128" alt="" /></a></a></p>
<p><a class="external" href="https://ci.arvados.org/view/Developer/job/developer-run-tests/2993/"<a href="https://ci.arvados.org/view/Developer/job/developer-run-tests/2993/">developer-run-tests: #2993 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=2993" alt="" /></a></a></p> Arvados - Feature #18896: [controller] should log the uuids of all tokens for each requesthttps://dev.arvados.org/issues/18896?journal_id=1021982022-03-28T13:53:00ZTom Cleggtom@curii.com
<ul></ul><p>This LGTM, thanks. Just a style nitpick, the "if ok"s should probably be "if !ok { return early }" instead of a pyramid. Could do this:</p>
<pre>
m, _ := ctx.Value(&mutexContextKey).(sync.Mutex)
c, _ := ctx.Value(&responseLogFieldsContextKey).(logrus.Fields)
if m == nil || c == nil {
return
}
// normal case
</pre> Arvados - Feature #18896: [controller] should log the uuids of all tokens for each requesthttps://dev.arvados.org/issues/18896?journal_id=1022002022-03-28T14:34:57ZWard Vandewegeward@curii.com
<ul></ul><p>Tom Clegg wrote:</p>
<blockquote>
<p>This LGTM, thanks. Just a style nitpick, the "if ok"s should probably be "if !ok { return early }" instead of a pyramid. Could do this:</p>
<p>[...]</p>
</blockquote>
<p>Thanks, done, and thanks for the test!</p>
<p><a class="external" href="https://ci.arvados.org/view/Developer/job/developer-run-tests/2998/"<a href="https://ci.arvados.org/view/Developer/job/developer-run-tests/2998/">developer-run-tests: #2998 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=2998" alt="" /></a></a></p> Arvados - Feature #18896: [controller] should log the uuids of all tokens for each requesthttps://dev.arvados.org/issues/18896?journal_id=1022312022-03-29T19:45:53ZWard Vandewegeward@curii.com
<ul><li><strong>Subject</strong> changed from <i>[controller] should log the uuid of the user and the uuid of the token for each request.</i> to <i>[controller] should log the uuids of all tokens for each request</i></li></ul> Arvados - Feature #18896: [controller] should log the uuids of all tokens for each requesthttps://dev.arvados.org/issues/18896?journal_id=1022322022-03-29T19:47:31ZWard Vandewegeward@curii.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-1 priority-4 priority-default" href="/issues/18944">Feature #18944</a>: [controller] should log the user uuid used for the request</i> added</li></ul> Arvados - Feature #18896: [controller] should log the uuids of all tokens for each requesthttps://dev.arvados.org/issues/18896?journal_id=1022342022-03-29T19:47:45ZWard Vandewegeward@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul> Arvados - Feature #18896: [controller] should log the uuids of all tokens for each requesthttps://dev.arvados.org/issues/18896?journal_id=1022382022-03-29T19:52:40ZWard Vandewegeward@curii.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-1 priority-4 priority-default" href="/issues/18897">Feature #18897</a>: [go services] should log the uuid of the token used for each request (and if available, the uuid of the associated user)</i> added</li></ul>