Project

General

Profile

Actions

Story #18948

closed

Container exit_code should be updated earlier, before copying staged outputs

Added by Tom Clegg 11 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Crunch
Target version:
Start date:
06/24/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Currently crunch-run updates exit_code and output at the same time, when setting state=Complete -- in fact, RailsAPI doesn't allow updating exit_code until state=Complete.

This means that in the case where outputs are staged in the local filesystem, the exit_code is not propagated back to the database / other clients / users until after copying staged outputs to keep, which can take a while. During that interval, the exit code is shown in the log, but not in the container record.

If we adjust the RailsAPI constraint, and have crunch-run save the exit_code as soon as it's known, workbench2 and other clients can easily show this to the user earlier.


Subtasks 1 (0 open1 closed)

Task #19210: Review 18948-update-exit-code-earlyResolvedLucas Di Pentima06/24/2022

Actions
Actions #1

Updated by Peter Amstutz 10 months ago

I think the reason for the current behavior was that if you don't have the outputs, the container isn't "finished". However we could relax the constraint so you can set the exit code but stay in Running state.

Actions #2

Updated by Peter Amstutz 10 months ago

  • Target version changed from 2022-04-27 Sprint to 2022-05-11 sprint
Actions #3

Updated by Peter Amstutz 10 months ago

  • Target version changed from 2022-05-11 sprint to 2022-05-25 sprint
Actions #4

Updated by Peter Amstutz 9 months ago

  • Target version changed from 2022-05-25 sprint to 2022-06-08 sprint
Actions #5

Updated by Peter Amstutz 9 months ago

  • Target version changed from 2022-06-08 sprint to 2022-06-22 Sprint
Actions #6

Updated by Peter Amstutz 8 months ago

  • Target version changed from 2022-06-22 Sprint to 2022-07-06
Actions #7

Updated by Peter Amstutz 8 months ago

  • Assigned To set to Tom Clegg
Actions #8

Updated by Tom Clegg 8 months ago

  • Status changed from New to In Progress
Actions #9

Updated by Lucas Di Pentima 8 months ago

This LGTM, thanks!

Actions #10

Updated by Tom Clegg 8 months ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados-private:commit:arvados|47e929743cefd13760b9c84e1c148115aa3fc96c.

Actions #11

Updated by Peter Amstutz about 2 months ago

  • Release set to 47
Actions

Also available in: Atom PDF