Arvados

Lucas Di Pentima wrote:

Updates at arvados-workbench2|20acf4ed - branch 18972-all-procs-flickering-fix

• Avoids the DataTable component to show a "loading" indication when the route didn't change. Attached video for easier confirmation.
• The loading indication should be still visible when navigating through a project hierarchy, for example.

This re-introduces a previous issue where you could hit the refresh button, but then because there isn't clear feedback that the refresh has completed, you go to try and click on something in the list, but the list contents changes underneath your mouse pointer, and you click on the wrong thing.

Could we make it so that when you hit the refresh button explicitly, it still clears the data table?

Peter Amstutz wrote:

This re-introduces a previous issue where you could hit the refresh button, but then because there isn't clear feedback that the refresh has completed, you go to try and click on something in the list, but the list contents changes underneath your mouse pointer, and you click on the wrong thing.
Could we make it so that when you hit the refresh button explicitly, it still clears the data table?

I didn't addressed the Refresh button case because I understood that the issue was when the user navigates through projects.

Updates at arvados-workbench2|f8033266 now make the Refresh button record its latest click timestamp on the localStorage so that any interested party could check if it changed from the last render and act upon it as necessary.

Lucas Di Pentima wrote:

Peter Amstutz wrote:

This re-introduces a previous issue where you could hit the refresh button, but then because there isn't clear feedback that the refresh has completed, you go to try and click on something in the list, but the list contents changes underneath your mouse pointer, and you click on the wrong thing.
Could we make it so that when you hit the refresh button explicitly, it still clears the data table?

I didn't addressed the Refresh button case because I understood that the issue was when the user navigates through projects.

It actually even came up in cypress testing, there was a test that used the refresh button, then immediately tried to click on something in the list and the list contents would get replaced underneath it and cause the click to open on the wrong list item.

Updates at arvados-workbench2|f8033266 now make the Refresh button record its latest click timestamp on the localStorage so that any interested party could check if it changed from the last render and act upon it as necessary.

Using global variables in data-explorer.tsx feels a little dodgy, should this be done through redux? Looks like Danny introduced the globals in 18207.

Rebased updates at arvados-workbench2|9858ad74 - developer-tests-workbench2: #666

Reimplements the "loading..." indicator behavior by using local state at the DataExplorer component. External dependencies (on Router & RefreshButton) are kept in the view component and passed down as optional props.

Lucas Di Pentima wrote:

Rebased updates at arvados-workbench2|9858ad74 - developer-tests-workbench2: #666

Reimplements the "loading..." indicator behavior by using local state at the DataExplorer component. External dependencies (on Router & RefreshButton) are kept in the view component and passed down as optional props.

I agree, keeping it as part of the data table state is much cleaner.

This LGTM!