Project

General

Profile

Actions

Feature #18975

closed

log viewer improvements

Added by Peter Amstutz 10 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
07/08/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

I'm using it to monitor the 2.4 test run.

https://workbench2.pirca.arvadosapi.com/processes/pirca-xvhdp-aiai8cvkddk1c4o

It's pretty great. I particularly like that when I've just started a workflow, the log panel is empty, but as soon as it starts running the logs start showing up, this gives good feedback.

  • bug: If you start from empty, and then it starts logging stuff, the "All logs" dropdown won't populate with the other log streams until you reload the panel
  • It would be nice if it started at the bottom and followed scroll by default, or had a button to do that
  • In fact, currently it doesn't seem to follow scrolling at all. It really needs to do that. I think the way wb1 does it is by checking if it is scrolled all the way to the bottom, and then when adding new text, it updates the scroll to ensure it is still scrolled to the bottom. (However if it is not scrolled all the way to the bottom, then it doesn't mess with the scroll position)
  • An option to show only crunch-run, stdout and stderr would be really great. If it was default, even better.
  • Can we make clickable links (PDHs and uuids) open in a new tab? It's annoying if I click on a link and when I come back to the panel I've lost all my UI state (like the scroll position).
  • Clickable link color is too dark against the black background

Out of scope (should be moved to their own tickets):

  • Logs for completed containers should be read from the log collection
  • Text search would be really great

Subtasks 1 (0 open1 closed)

Task #18999: Review 18975-log-improvementsResolvedPeter Amstutz07/08/2022

Actions
Actions #1

Updated by Peter Amstutz 10 months ago

  • Description updated (diff)
Actions #2

Updated by Peter Amstutz 10 months ago

  • Description updated (diff)
Actions #3

Updated by Lucas Di Pentima 10 months ago

  • Assigned To set to Lucas Di Pentima
Actions #4

Updated by Peter Amstutz 10 months ago

  • Target version changed from 2022-04-27 Sprint to 2022-05-11 sprint
Actions #5

Updated by Peter Amstutz 10 months ago

  • Target version changed from 2022-05-11 sprint to 2022-05-25 sprint
Actions #6

Updated by Peter Amstutz 9 months ago

  • Target version changed from 2022-05-25 sprint to 2022-06-08 sprint
Actions #7

Updated by Peter Amstutz 8 months ago

  • Target version changed from 2022-06-08 sprint to 2022-06-22 Sprint
Actions #8

Updated by Lucas Di Pentima 8 months ago

  • Target version changed from 2022-06-22 Sprint to 2022-07-06
Actions #9

Updated by Peter Amstutz 7 months ago

  • Description updated (diff)
Actions #10

Updated by Peter Amstutz 7 months ago

  • Description updated (diff)
Actions #11

Updated by Peter Amstutz 7 months ago

  • Description updated (diff)
Actions #12

Updated by Lucas Di Pentima 7 months ago

  • Status changed from New to In Progress
Actions #13

Updated by Lucas Di Pentima 7 months ago

  • Target version changed from 2022-07-06 to 2022-07-20
Actions #14

Updated by Lucas Di Pentima 7 months ago

Updates at arvados-workbench2|9ae74b6d - branch 18975-log-improvements
Test run: developer-tests-workbench2: #771

  • Improves link coloring by using light green for better contrast against the background.
  • Adds a "Main log" filter (selected by default because it's the first) that only shows crunch-run, stdout and stderr streams.
  • Makes new arriving event types populate the filter drop down list.
  • Bonus: Adds "keepstore" stream to the list (just realized that those logs will be available when using a local keepstore)
  • Enables "follow mode" by default.
  • Fixes "follow mode" when the panel is maximized by adding some margin to the scrolling & height calculations.
  • Opens a new tab when clicking linked (and recognizable) UUIDs and PDHs.
  • Bonus: improves the word-wrapping indication by changing the button's icon & tooltip.
Actions #15

Updated by Lucas Di Pentima 7 months ago

Although Cypress tests are failing on Jenkins, I was able to run them without issues in docker on my local VM.

Actions #16

Updated by Peter Amstutz 7 months ago

Lucas Di Pentima wrote in #note-14:

Updates at arvados-workbench2|9ae74b6d - branch 18975-log-improvements
Test run: developer-tests-workbench2: #771

  • Improves link coloring by using light green for better contrast against the background.
  • Adds a "Main log" filter (selected by default because it's the first) that only shows crunch-run, stdout and stderr streams.
  • Makes new arriving event types populate the filter drop down list.
  • Bonus: Adds "keepstore" stream to the list (just realized that those logs will be available when using a local keepstore)
  • Enables "follow mode" by default.
  • Fixes "follow mode" when the panel is maximized by adding some margin to the scrolling & height calculations.
  • Opens a new tab when clicking linked (and recognizable) UUIDs and PDHs.
  • Bonus: improves the word-wrapping indication by changing the button's icon & tooltip.

I know you are still fighting with the testing. Functionally, this seems like a great improvement, thank you! LGTM

Actions #17

Updated by Lucas Di Pentima 7 months ago

I was able to get a successful test run by using a worker node with 8GB of RAM: developer-tests-workbench2: #805

Actions #18

Updated by Lucas Di Pentima 7 months ago

  • Status changed from In Progress to Resolved
Actions #19

Updated by Peter Amstutz 6 months ago

  • Release set to 52
Actions

Also available in: Atom PDF