Project

General

Profile

Actions

Bug #18979

closed

Missing VM login, user names not rendered

Added by Peter Amstutz 10 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
09/28/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

On pirca.arvadosapi.com

Go to workbench 2

  • Go to admin view for virtual machines -- all the user accounts are rendered as uuids, not users. Possibly because they are federated accounts? But should be possible to get user names for federated users.
  • also, it should render the username, not the full name or email address

2nd problem

  1. Go to user view of VMs as me
  2. My can_login permission link "pirca-o0j2j-vts284swp2o6vgv" is not displayed. It does show up in workbench 1.
  3. Since I didn't see any logins, I added one (and noticed the 1st problem of user account names not shown). Now I have two can_login links.
  4. The second one (pirca-o0j2j-i1decomuvw455rd) does show up. I try to log in with webshell and I run into #18978
  5. If I go to workbench 1 VM list, I see both can_login entries.

3rd problem

  1. If the window is too narrow, it doesn't render a horizontal scroll bar, and the right part of the row (e.g. the "log in to web shell" button) is cut off entirely

Files


Subtasks 1 (0 open1 closed)

Task #19005: Review 18979-vm-login-uiResolvedPeter Amstutz09/28/2022

Actions
Actions #1

Updated by Peter Amstutz 10 months ago

  • Description updated (diff)
Actions #2

Updated by Peter Amstutz 10 months ago

  • Description updated (diff)
Actions #3

Updated by Peter Amstutz 10 months ago

  • Description updated (diff)
Actions #4

Updated by Peter Amstutz 10 months ago

  • Assigned To set to Stephen Smith
Actions #5

Updated by Stephen Smith 10 months ago

  • Status changed from New to In Progress
Actions #6

Updated by Peter Amstutz 10 months ago

  • Target version changed from 2022-04-27 Sprint to 2022-05-11 sprint
Actions #7

Updated by Peter Amstutz 9 months ago

  • Target version changed from 2022-05-11 sprint to 2022-05-25 sprint
Actions #8

Updated by Peter Amstutz 9 months ago

  • Target version changed from 2022-05-25 sprint to 2022-06-08 sprint
Actions #9

Updated by Peter Amstutz 8 months ago

  • Target version changed from 2022-06-08 sprint to 2022-06-22 Sprint
Actions #10

Updated by Peter Amstutz 8 months ago

  • Target version changed from 2022-06-22 Sprint to 2022-07-06
Actions #11

Updated by Peter Amstutz 7 months ago

  • Target version changed from 2022-07-06 to 2022-07-20
Actions #12

Updated by Peter Amstutz 7 months ago

  • Target version changed from 2022-07-20 to 2022-08-03 Sprint
Actions #13

Updated by Peter Amstutz 6 months ago

  • Target version changed from 2022-08-03 Sprint to 2022-08-17 sprint
Actions #14

Updated by Stephen Smith 6 months ago

Additional bug: adding groups to login - any un-tokenized group after the first are lost when submitting the update form.

Actions #15

Updated by Stephen Smith 6 months ago

Changes at arvados-workbench2|1591e11e1f0344c16b1ee05dcf21bdef483aa59a
Tests developer-tests-workbench2: #850

  • Increased query limit to 1000 for fetching login permissions
  • Added horizontal scroll when screen is too small
  • Disable submitting add/update login form when unsaved group value is present - also add a validation message * This one was a bit tricky since the partial input state is in the chips input component state - instead of hoisting the state into the many consumers of chips input, I added a bool flag to the add login dialog which made it easier to access this info in the components between the form and the input - where the redux Field component is which is still above the input component itself.
Actions #16

Updated by Peter Amstutz 6 months ago

  • Target version changed from 2022-08-17 sprint to 2022-08-31 sprint
Actions #17

Updated by Peter Amstutz 5 months ago

  • Target version changed from 2022-08-31 sprint to 2022-09-14 sprint
Actions #19

Updated by Peter Amstutz 5 months ago

  • Target version changed from 2022-09-14 sprint to 2022-09-28 sprint
Actions #20

Updated by Peter Amstutz 4 months ago

  • Target version changed from 2022-09-28 sprint to 2022-10-12 sprint
Actions #21

Updated by Peter Amstutz 4 months ago

18979-vm-login-ui @ commit:0f55c7182b5231712e77f2538dd0c69336558647

1. On the admin page for VMs it is loading more logins, but it isn't loading all the names. Maybe getting the users also needs limit=1000?

To be honest, with more than a handful of accounts the chips interface doesn't work at all. We should probably move to something like the groups view where you have a list of VMs, and then click on a VM to get a separate paged list of members. That is probably a story for a separate ticket, though.

2. The VM page for users is straight up broken for me. When I navigate to it on pirca, it briefly flickers showing me two entries, then nothing:

When I go to workbench 1, it shows that I have a login, although it is listed twice -- somehow I probably ended up with a duplicate login link. Is that the problem, or is it something else?

We need to prevent that from happening (#19057) but in the meantime the UI shouldn't fail.

Actions #22

Updated by Stephen Smith 4 months ago

Changes at arvados-workbench2|5f11a35f157af618340d5ce6d64694b15bfe2f8a
Tests developer-tests-workbench2: #946

  • Use urlencoded post body for large list requests in common resource service - fixes incorrect limit / names not showing up
  • Add filter to user vm panel to just fetch user's own login permissions - fixes missing permission links
Actions #23

Updated by Peter Amstutz 4 months ago

Stephen Smith wrote in #note-22:

Changes at arvados-workbench2|5f11a35f157af618340d5ce6d64694b15bfe2f8a
Tests developer-tests-workbench2: #946

  • Use urlencoded post body for large list requests in common resource service - fixes incorrect limit / names not showing up
  • Add filter to user vm panel to just fetch user's own login permissions - fixes missing permission links

This works now, thanks! LGTM

Actions #24

Updated by Stephen Smith 4 months ago

  • Status changed from In Progress to Resolved
Actions #25

Updated by Peter Amstutz about 2 months ago

  • Release set to 47
Actions

Also available in: Atom PDF