Project

General

Profile

Actions

Bug #18994

closed

Changing basename does not change filename it materializes as

Added by Peter Amstutz 4 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
CWL
Target version:
Start date:
04/14/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Subtasks 1 (0 open1 closed)

Task #19004: Review 18994-cwl-basenameResolvedPeter Amstutz04/14/2022

Actions

Related issues

Related to Arvados - Bug #18614: CWL colon_in_output_path conformance test failingResolvedPeter Amstutz

Actions
Actions #1

Updated by Peter Amstutz 4 months ago

  • Status changed from New to In Progress
Actions #2

Updated by Peter Amstutz 4 months ago

  • Assigned To set to Peter Amstutz
  • Status changed from In Progress to New
  • Category set to CWL
Actions #3

Updated by Peter Amstutz 4 months ago

18994-cwl-basename @ bf95fa077c79c6bd4ac548ec534b618e97e3f00b

  • Added integration test for this case
  • Now includes check for "basename" in check whether input files need to be re-staged into a new intermediate collection
  • The actual re-staging already uses basename correctly

developer-run-tests: #3056

Actions #4

Updated by Peter Amstutz 4 months ago

18994-cwl-basename @ 5d039c344850dfc5fedd03c1050fa51eec404d72

  • Fix tests
  • Better handling of optional dependencies
  • Bonus fix for #18614
  • passed CWL conformance tests on arvbox
  • passed Arvados CWL integration tests on arvbox

developer-run-tests: #3066

re-run: developer-run-tests-apps-workbench-integration: #3275

re-run: developer-run-tests-apps-workbench-integration: #3276

Actions #5

Updated by Peter Amstutz 4 months ago

  • Status changed from New to In Progress
Actions #6

Updated by Lucas Di Pentima 4 months ago

Just one observation:

  • In runner.py there're a number of commented out code lines left.

The rest LGTM

Actions #7

Updated by Peter Amstutz 4 months ago

  • Release set to 51
Actions #8

Updated by Peter Amstutz 4 months ago

  • Related to Bug #18614: CWL colon_in_output_path conformance test failing added
Actions #9

Updated by Peter Amstutz 4 months ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF