Project

General

Profile

Actions

Bug #19007

closed

Investigate why the 3-dot action menu is gone in file browser

Added by Peter Amstutz 3 months ago. Updated 16 days ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
06/10/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Subtasks 1 (0 open1 closed)

Task #19114: Review 19007-file-browser-action-buttonResolvedLucas Di Pentima06/10/2022

Actions
Actions #1

Updated by Peter Amstutz 2 months ago

  • Target version changed from 2022-04-27 Sprint to 2022-05-11 sprint
Actions #2

Updated by Peter Amstutz 2 months ago

  • Target version changed from 2022-05-11 sprint to 2022-05-25 sprint
Actions #3

Updated by Lucas Di Pentima about 1 month ago

  • Target version changed from 2022-05-25 sprint to 2022-06-08 sprint
Actions #4

Updated by Peter Amstutz 25 days ago

  • Target version changed from 2022-06-08 sprint to 2022-06-22 Sprint
Actions #5

Updated by Lucas Di Pentima 24 days ago

  • Status changed from New to In Progress
Actions #6

Updated by Lucas Di Pentima 24 days ago

The "More options" IconButton seems to have been eliminated because a global click handler was put in place to capture and process all the file browser's clicks on a single function. The file's checkboxes are special-cased, so I'll try to do the same on every "More options" button.

Actions #7

Updated by Lucas Di Pentima 23 days ago

Updates at arvados-workbench2|5550460 - branch 19007-file-browser-action-button
Test run: developer-tests-workbench2: #747

  • Brings back the 3-dotted "More options" menu on the file browser.
  • Cleans up old file browser code.
  • Adds assertions to the Cypress for the new UI element.
Actions #8

Updated by Tom Clegg 18 days ago

I haven't even had a chance to build/test yet, but to show that I'm paying attention, here is a missing semicolon in cypress/integration/collection.spec.js (prevailing style seems to be including the usually-optional semicolon, which makes sense)

                         cy.get('[data-cy=file-item-options-btn')
                             .first()
-                            .click()
+                            .click();
                         cy.get('[data-cy=context-menu]')
Actions #9

Updated by Tom Clegg 17 days ago

Managed to start dev instance, restored menu works. LGTM!

Actions #10

Updated by Lucas Di Pentima 16 days ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF