Project

General

Profile

Actions

Bug #19049

closed

VM admin interface rough edges

Added by Ward Vandewege 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Start date:
05/13/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Observed on 9tee4 at v2.5.0~dev20220419201321:

  • when adding a user to a shell machine, the "Add login permission" dropdown shows double smaller/greater than symbols around the e-mail address
  • when adding a user to a shell machine, only the name and e-mail is shown. If there are users with identical name/e-mail addresses (e.g. on 9tee4), it is impossible to tell which is which. I suggest the UUID for the user is added at the end, perhaps between parentheses.
  • when adding a user to a shell machine, all users show up in the search list, even if they have already been added to the shell machine. Suggest limiting the list to users not yet on the shell machine.
  • when adding a user to a shell machine, if a user is selected that is already on the shell machine, the user gets added again (see also previous point, if they are no longer selectable, this one will also be fixed automatically). See also #19057, controller should not allow this.
  • when adding a user to a shell machine, for some users (federated users?) I get a "Not Found" popup, and also an empty red box at the bottom left: I think the user in the example is uuid ce8i5-tpzed-xo2k4i24bjzwedw, but it's hard to be sure until the second bullet on this list is fixed.

Files

20220425-user-add-404.png (88.6 KB) 20220425-user-add-404.png Ward Vandewege, 04/25/2022 12:45 PM

Subtasks 1 (0 open1 closed)

Arvados - Task #19061: Review 19049-vm-admin-rough-edgesResolvedStephen Smith05/13/2022

Actions

Related issues

Related to Arvados - Bug #19057: [controller] should not allow adding the same user to a VM more than one timeNew

Actions
Actions #1

Updated by Ward Vandewege 2 months ago

Actions #2

Updated by Ward Vandewege 2 months ago

  • Description updated (diff)
Actions #3

Updated by Ward Vandewege 2 months ago

  • Related to Bug #19057: [controller] should not allow adding the same user to a VM more than one time added
Actions #4

Updated by Ward Vandewege 2 months ago

  • Description updated (diff)
Actions #5

Updated by Peter Amstutz 2 months ago

  • Assigned To set to Stephen Smith
Actions #6

Updated by Stephen Smith 2 months ago

  • Status changed from New to In Progress
Actions #7

Updated by Peter Amstutz about 2 months ago

  • Target version changed from 2022-05-11 sprint to 2022-05-25 sprint
Actions #8

Updated by Stephen Smith about 2 months ago

Changes at arvados-workbench2|8e191ecaf0e507dd1d685ca3ebeab954652d8e9e branch 19049-vm-admin-rough-edges
Tests developer-tests-workbench2: #685

  • Clean up displayed user info in picker
  • Add uuid to participant picker
  • Exclude existing logins from picker
  • Change edit login user to read only
  • Improve error handling on inaccessible user records
  • Add waitfordom to a few flakey cypress tests & prevent cypress default timeout from prematurely exiting waitfordom
Actions #9

Updated by Ward Vandewege about 2 months ago

Stephen Smith wrote:

Changes at arvados-workbench2|8e191ecaf0e507dd1d685ca3ebeab954652d8e9e branch 19049-vm-admin-rough-edges
Tests developer-tests-workbench2: #685

  • Clean up displayed user info in picker
  • Add uuid to participant picker
  • Exclude existing logins from picker
  • Change edit login user to read only
  • Improve error handling on inaccessible user records
  • Add waitfordom to a few flakey cypress tests & prevent cypress default timeout from prematurely exiting waitfordom

Thanks this is so much better!! I found one more thing:

  • when selecting users to add, inactive users are also showing up in the dropdown. Can that be fixed?

Other than that, LGTM!

Actions #11

Updated by Stephen Smith about 2 months ago

  • Status changed from In Progress to Resolved
Actions #12

Updated by Peter Amstutz about 1 month ago

  • Release set to 51
Actions

Also available in: Atom PDF