Arvados

to do:

• Fix sizing when there are lots of input parameters
• Use shortname not full id when no label is available
• Hide broken 'graph' tab

19069-workflow-launching @ arvados-workbench2|8dce1fa34833d40dad114eed8895fd5e6d7df28d

• Hide the broken, mostly redundant workflow panel from the left tree
  (can still launch workflows from "+NEW -> Run a process")
• Hide unsupported "presets" element
• Don't require #main to be a workflow
• Change "workflowUuid" property to "template_uuid" property for
  consistency with existing usage in workbench 1 and arvados-cwl-runner
• Give process a default name
• Assign default output collection name "Output of {name}"
• Scroll instead of overflow in run a process
• Rename "Run a process" button to "Run a workflow"
• Replace "Graph" tab with "Details"

developer-tests-workbench2: #690

developer-tests-workbench2: #691

developer-tests-workbench2: #693

• When clicking on "+NEW" -> "Run a workflow", the panel's breadcrumb shows "Run Process", I think it would be good idea to have consistency there.
• Unused import at src/views/run-process-panel/run-process-second-step.tsx:L16
• The use of SidePanelTreeCategory.WORKFLOWS is commented out at src/store/side-panel-tree/side-panel-tree-actions.ts:L55. Removing that category from line 26 shows many code cleanup opportunities.
• Commented out code left at src/views/run-process-panel/run-process-second-step.tsx
• Commented out code left at src/views/workflow-panel/workflow-description-card.tsx, also if we're not using src/views/workflow-panel/workflow-graph.tsx I think we should remove it.
• Commented out code left at test file cypress/integration/side-panel.spec.js:L65
• We usually use the "zzzzz" cluster prefix for testing, do you think this is a good opportunity to fix the "ce8i5" references on src/store/run-process-panel/run-process-panel-actions.test.ts?
• I believe this ticket was created from a user report that some kind of input wasn't being displayed. Would it be convenient to add that as a test case?

Lucas Di Pentima wrote:

• When clicking on "+NEW" -> "Run a workflow", the panel's breadcrumb shows "Run Process", I think it would be good idea to have consistency there.

Fixed.

• Unused import at src/views/run-process-panel/run-process-second-step.tsx:L16

Fixed.

• The use of SidePanelTreeCategory.WORKFLOWS is commented out at src/store/side-panel-tree/side-panel-tree-actions.ts:L55. Removing that category from line 26 shows many code cleanup opportunities.

Removed it from many places.

• Commented out code left at src/views/run-process-panel/run-process-second-step.tsx
• Commented out code left at src/views/workflow-panel/workflow-description-card.tsx, also if we're not using src/views/workflow-panel/workflow-graph.tsx I think we should remove it.
• Commented out code left at test file cypress/integration/side-panel.spec.js:L65
• We usually use the "zzzzz" cluster prefix for testing, do you think this is a good opportunity to fix the "ce8i5" references on src/store/run-process-panel/run-process-panel-actions.test.ts?

Fixed

• I believe this ticket was created from a user report that some kind of input wasn't being displayed. Would it be convenient to add that as a test case?

The issue turned out to be that it was filtering on Workflows in the document, which meant it wouldn't run CommandLineTool items even though they work just fine.

I'm going to follow up with tests but I want to get this merged sooner rather than later.

developer-tests-workbench2: #712

arvados-workbench2|ae6892150bb19c974d8af4cb323760f52a2ea19e

arvados-workbench2|ea78e1afd181e1e6bf667cce24ad101e39d78b78

developer-tests-workbench2: #713

This LGTM, thanks!