Project

General

Profile

Actions

Bug #19069

closed

launch workflow improvements

Added by Peter Amstutz 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
05/19/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Fix up usability problems with launching workflows in workbench 2.


Subtasks 1 (0 open1 closed)

Task #19122: Review 19069-workflow-launchingResolvedPeter Amstutz05/19/2022

Actions

Related issues

Related to Arvados - Feature #19086: Can provide input JSON/YAML when launching a Workflow as an alternative to the input formNewPeter Amstutz

Actions
Related to Arvados - Bug #19143: Display 'Workflow' records in the Project listingIn ProgressPeter Amstutz05/20/2022

Actions
Actions #1

Updated by Peter Amstutz 2 months ago

  • Subject changed from running workflow not showing [null, string] input types? to launch workflow not showing [null, string] input types?
Actions #2

Updated by Peter Amstutz 2 months ago

  • Target version changed from 2022-05-11 sprint to 2022-05-25 sprint
Actions #3

Updated by Peter Amstutz about 2 months ago

  • Description updated (diff)
Actions #4

Updated by Peter Amstutz about 2 months ago

  • Assigned To set to Peter Amstutz
Actions #5

Updated by Peter Amstutz about 2 months ago

  • Related to Feature #19086: Can provide input JSON/YAML when launching a Workflow as an alternative to the input form added
Actions #6

Updated by Peter Amstutz about 2 months ago

  • Subject changed from launch workflow not showing [null, string] input types? to launch workflow improvements
Actions #7

Updated by Peter Amstutz about 2 months ago

to do:

  • Fix sizing when there are lots of input parameters
  • Use shortname not full id when no label is available
  • Hide broken 'graph' tab
Actions #8

Updated by Peter Amstutz about 2 months ago

19069-workflow-launching @ arvados-workbench2|8dce1fa34833d40dad114eed8895fd5e6d7df28d

  • Hide the broken, mostly redundant workflow panel from the left tree
    (can still launch workflows from "+NEW -> Run a process")
  • Hide unsupported "presets" element
  • Don't require #main to be a workflow
  • Change "workflowUuid" property to "template_uuid" property for
    consistency with existing usage in workbench 1 and arvados-cwl-runner
  • Give process a default name
  • Assign default output collection name "Output of {name}"
  • Scroll instead of overflow in run a process
  • Rename "Run a process" button to "Run a workflow"
  • Replace "Graph" tab with "Details"

developer-tests-workbench2: #690

Actions #9

Updated by Peter Amstutz about 2 months ago

  • Description updated (diff)
Actions #12

Updated by Peter Amstutz about 1 month ago

  • Status changed from New to In Progress
Actions #13

Updated by Lucas Di Pentima about 1 month ago

  • When clicking on "+NEW" -> "Run a workflow", the panel's breadcrumb shows "Run Process", I think it would be good idea to have consistency there.
  • Unused import at src/views/run-process-panel/run-process-second-step.tsx:L16
  • The use of SidePanelTreeCategory.WORKFLOWS is commented out at src/store/side-panel-tree/side-panel-tree-actions.ts:L55. Removing that category from line 26 shows many code cleanup opportunities.
  • Commented out code left at src/views/run-process-panel/run-process-second-step.tsx
  • Commented out code left at src/views/workflow-panel/workflow-description-card.tsx, also if we're not using src/views/workflow-panel/workflow-graph.tsx I think we should remove it.
  • Commented out code left at test file cypress/integration/side-panel.spec.js:L65
  • We usually use the "zzzzz" cluster prefix for testing, do you think this is a good opportunity to fix the "ce8i5" references on src/store/run-process-panel/run-process-panel-actions.test.ts?
  • I believe this ticket was created from a user report that some kind of input wasn't being displayed. Would it be convenient to add that as a test case?
Actions #14

Updated by Peter Amstutz about 1 month ago

  • Release set to 51
Actions #15

Updated by Peter Amstutz about 1 month ago

  • Target version changed from 2022-05-25 sprint to 2022-06-08 sprint
Actions #16

Updated by Peter Amstutz about 1 month ago

Lucas Di Pentima wrote:

  • When clicking on "+NEW" -> "Run a workflow", the panel's breadcrumb shows "Run Process", I think it would be good idea to have consistency there.

Fixed.

  • Unused import at src/views/run-process-panel/run-process-second-step.tsx:L16

Fixed.

  • The use of SidePanelTreeCategory.WORKFLOWS is commented out at src/store/side-panel-tree/side-panel-tree-actions.ts:L55. Removing that category from line 26 shows many code cleanup opportunities.

Removed it from many places.

  • Commented out code left at src/views/run-process-panel/run-process-second-step.tsx
  • Commented out code left at src/views/workflow-panel/workflow-description-card.tsx, also if we're not using src/views/workflow-panel/workflow-graph.tsx I think we should remove it.
  • Commented out code left at test file cypress/integration/side-panel.spec.js:L65
  • We usually use the "zzzzz" cluster prefix for testing, do you think this is a good opportunity to fix the "ce8i5" references on src/store/run-process-panel/run-process-panel-actions.test.ts?

Fixed

  • I believe this ticket was created from a user report that some kind of input wasn't being displayed. Would it be convenient to add that as a test case?

The issue turned out to be that it was filtering on Workflows in the document, which meant it wouldn't run CommandLineTool items even though they work just fine.

I'm going to follow up with tests but I want to get this merged sooner rather than later.

developer-tests-workbench2: #712

arvados-workbench2|ae6892150bb19c974d8af4cb323760f52a2ea19e

Actions #18

Updated by Peter Amstutz about 1 month ago

  • Related to Bug #19143: Display 'Workflow' records in the Project listing added
Actions #19

Updated by Lucas Di Pentima about 1 month ago

This LGTM, thanks!

Actions #20

Updated by Peter Amstutz about 1 month ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF