Project

General

Profile

Actions

Feature #19079

closed

Need to be able to open links from advance search in new tab

Added by Peter Amstutz 7 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
06/23/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

When doing an advanced search, if you click on a link and then go back to search, you lose all your state (not only the position in the list, but you were deep into paging with "Load more" then you have to reload all those pages.) Right clicking on the link neither brings up a wb2 context menu, nor a browser context menu that would allow you to open in a new tab.

Should support right clicking "Open in new tab", or always open in new tab by default.


Subtasks 1 (0 open1 closed)

Task #19187: Review 19079-search-results-open-newtabResolvedLucas Di Pentima06/23/2022

Actions
Actions #1

Updated by Peter Amstutz 7 months ago

  • Status changed from New to In Progress
Actions #2

Updated by Peter Amstutz 7 months ago

  • Status changed from In Progress to New

When doing an advanced search, if you click on a link and then go back to search, you lose all your state (not only the position in the list, but you were deep into paging with "Load more" then you have to reload all those pages.) Right clicking on the link neither brings up a wb2 context menu, nor a browser context menu that would allow you to open in a new tab.

Should support right clicking "Open in new tab", or always open in new tab by default.

Actions #3

Updated by Peter Amstutz 7 months ago

  • Target version changed from 2022-05-11 sprint to 2022-05-25 sprint
Actions #4

Updated by Peter Amstutz 7 months ago

  • Category set to Workbench2
  • Tracker changed from Bug to Feature
Actions #5

Updated by Peter Amstutz 7 months ago

  • Target version changed from 2022-05-25 sprint to 2022-06-08 sprint
Actions #6

Updated by Peter Amstutz 7 months ago

  • Target version changed from 2022-06-08 sprint to 2022-06-22 Sprint
Actions #7

Updated by Peter Amstutz 6 months ago

  • Description updated (diff)
Actions #8

Updated by Peter Amstutz 6 months ago

  • Assigned To set to Stephen Smith
Actions #9

Updated by Peter Amstutz 6 months ago

  • Target version changed from 2022-06-22 Sprint to 2022-07-06
Actions #10

Updated by Stephen Smith 6 months ago

  • Status changed from New to In Progress
Actions #11

Updated by Stephen Smith 6 months ago

Changes at arvados-workbench2|967a861f541ec6e8ef26cd794e7f7890ae65bef7 branch 19079-dual-mode-nav-links
Tests developer-tests-workbench2: #764

  • Adds anchor element around rendered names with nav action to enable middle and right click on object names
  • onClick is disabled to allow the nav function to handle left click routing
  • Right click isn't interfered with so areas using context menu still receive the event and override the browser context menu
Actions #12

Updated by Peter Amstutz 6 months ago

  • Release set to 52
Actions #13

Updated by Lucas Di Pentima 6 months ago

Some comments:

  • Upon first experimentation, I believe using the browser's right-click menu to allow the user open a search result in a new tab/window would bring issues when the cluster config is set in a way that makes Workbench2 save its credentials on session storage (as it's the case of ce8i5, for example)
  • What I think Peter was originally aiming is to have something equivalent to the "Open in new tab" context menu item that we already have on project listings (projects & collections, it seems that processes are also needing it), that already works fine with wb2 session storage usage.
  • I personally think using one version of context menu is a lot better for consistency reasons. Using a react-based context menu also allows us to test it with Cypress, that I believe won't be possible otherwise?

If in doubt, let's double-check with Peter.

Actions #14

Updated by Peter Amstutz 6 months ago

Yes, I agree with Lucas.

Actions #15

Updated by Peter Amstutz 5 months ago

  • Target version changed from 2022-07-06 to 2022-07-20
Actions #16

Updated by Peter Amstutz 5 months ago

  • Target version changed from 2022-07-20 to 2022-08-03 Sprint
Actions #17

Updated by Stephen Smith 4 months ago

Changes at arvados-workbench2|6aa9f73fef64bbca1e3b71eb526946d69d014246 branch 19079-search-results-open-newtab
Tests developer-tests-workbench2: #826

  • Added a search context menu with a few basic options (advanced, details, new tab, and copy to clipboard), since the full featured context menus for each resource kind don't work out of the box without tweaking each action
  • Added cypress tests for clipboard and new tab
Actions #18

Updated by Lucas Di Pentima 4 months ago

  • The new cypress test is being called with .only()
  • I've tried it on ce8i5 and seems to work great, except for one edge case: When having search results from other clusters (like: tordo), the simple click will take the browser to the remote cluster's wb2, but the "Open in new tab" and "Copy to clipboard" will use the local wb2 URL.
Actions #19

Updated by Stephen Smith 4 months ago

Changes at arvados-workbench2|d6e180f251c934a6c9b504eae5bbe50215240e19
Tests developer-tests-workbench2: #829

  • For the federated case for copy to clipboard, I switched to getNavUrl which I added a flag to omit the token (to behave similarly to getClipboardUrl, which I renamed to getCollectionItemClipboardUrl since that function is exclusively for keep-web URLs, and the token sanitization there doesn't work on the getNavUrl value when it does add a token anyway)
  • Also added mock remote cluster & cluster config using cy.intercept
Actions #20

Updated by Lucas Di Pentima 4 months ago

This LGTM, thanks!

Actions #22

Updated by Stephen Smith 4 months ago

  • Status changed from In Progress to Resolved
Actions #23

Updated by Peter Amstutz 4 months ago

  • Release deleted (52)
Actions #24

Updated by Peter Amstutz 3 months ago

  • Release set to 53
Actions

Also available in: Atom PDF