Project

General

Profile

Actions

Feature #19093

closed

Process details should display a warning if "container_count" is greater than 1 (meaning it failed and was retried)

Added by Peter Amstutz 9 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
06/23/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Subtasks 1 (0 open1 closed)

Task #19186: Review 19093-process-failed-warningResolvedLucas Di Pentima06/23/2022

Actions

Related issues

Related to Arvados - Story #18860: Display count of container attempts and make it easy to access past logsNew

Actions
Actions #1

Updated by Peter Amstutz 9 months ago

  • Target version changed from 2022-05-25 sprint to 2022-06-08 sprint
Actions #2

Updated by Peter Amstutz 9 months ago

  • Target version changed from 2022-06-08 sprint to 2022-06-22 Sprint
Actions #3

Updated by Peter Amstutz 8 months ago

  • Assigned To set to Stephen Smith
Actions #4

Updated by Stephen Smith 8 months ago

  • Status changed from New to In Progress
Actions #5

Updated by Peter Amstutz 8 months ago

  • Target version changed from 2022-06-22 Sprint to 2022-07-06
Actions #6

Updated by Peter Amstutz 8 months ago

  • Target version changed from 2022-07-06 to 2022-06-22 Sprint
Actions #7

Updated by Peter Amstutz 8 months ago

  • Target version changed from 2022-06-22 Sprint to 2022-07-06
Actions #8

Updated by Stephen Smith 8 months ago

Changes at arvados-workbench2|3ebe70ccec47fe17491415736701e6e1ce1956c3 branch 19093-process-failed-warning
Tests developer-tests-workbench2: #763

  • Adds an additional process details attributes warning banner when container count > 1
Actions #9

Updated by Lucas Di Pentima 8 months ago

Some comments:

  • The data-cy=process-runtime-status-warning property is meant for Cypress tests to find the original runtime status warning, so I think in the case of the container_count warning, it should have its own identifier.
  • The expansion component allows to show additional information that in this case isn't available, do you think it would be better to use for example the Paper component ? For example, I think Paper won't need special CSS rules to disable unwanted pointer behavior.
  • Could you add a Cypress test on process.spec.js?
Actions #10

Updated by Stephen Smith 8 months ago

Changes at arvados-workbench2|25d64433dff3ffcf083c2cedd8d849de49a691d1
Tests developer-tests-workbench2: #766

  • Swapped out for Paper
  • Added cypress tests with cy.intercept
Actions #11

Updated by Lucas Di Pentima 8 months ago

Really cool what cy.intercept allows us to do! LGTM, thanks.

Actions #12

Updated by Stephen Smith 8 months ago

  • Status changed from In Progress to Resolved
Actions #13

Updated by Stephen Smith 2 months ago

  • Related to Story #18860: Display count of container attempts and make it easy to access past logs added
Actions #14

Updated by Peter Amstutz about 2 months ago

  • Release set to 47
Actions

Also available in: Atom PDF