Project

General

Profile

Actions

Bug #19109

closed

Secondary files not found when input is optional; also expressions not handled correctly

Added by Peter Amstutz about 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
CWL
Target version:
Start date:
05/11/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

When input is optional, it doesn't find secondary files.

When secondary file is an expression, it is treating the return value as a file extension instead of a replacement base name.


Subtasks 1 (0 open1 closed)

Task #19110: Review 19109-upload-secondaryResolvedPeter Amstutz05/11/2022

Actions
Actions #1

Updated by Peter Amstutz about 2 months ago

  • Assigned To set to Peter Amstutz
Actions #2

Updated by Peter Amstutz about 2 months ago

  • Status changed from New to In Progress
Actions #3

Updated by Peter Amstutz about 2 months ago

  • Assigned To deleted (Peter Amstutz)
  • Status changed from In Progress to New
  • Description updated (diff)
  • Subject changed from Ensure that local secondary files are uploaded to Secondary files not found when input is optional; also expressions not handled correctly
Actions #4

Updated by Peter Amstutz about 2 months ago

  • Status changed from New to In Progress
Actions #5

Updated by Peter Amstutz about 2 months ago

  • Target version changed from 2022-05-11 sprint to 2022-05-25 sprint
Actions #6

Updated by Peter Amstutz about 2 months ago

  • Assigned To set to Peter Amstutz
Actions #7

Updated by Peter Amstutz about 2 months ago

to do: contribute this as a test case to CWL conformance suite.

Actions #8

Updated by Peter Amstutz about 2 months ago

19109-upload-secondary @ 12e0b04c56f0e1ba9dd0f0450d9e96ceee04f1b7

  • Fix bug where it would not find secondary files when an inputs is optional
  • Fix bug using expressions to specify secondary file

developer-run-tests: #3113

Actions #9

Updated by Lucas Di Pentima about 2 months ago

Re-ran tests and failed again: developer-run-tests-remainder: #3258

Actions #11

Updated by Lucas Di Pentima about 2 months ago

This LGTM, please merge.

Actions #12

Updated by Peter Amstutz about 2 months ago

  • Release set to 51
Actions #13

Updated by Peter Amstutz about 1 month ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF