Project

General

Profile

Actions

Task #19142

closed

Workbench 2: Avoid loading "mounts" section in the "Project" or "All process" view

Added by Peter Amstutz 7 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
08/04/2022
Due date:
% Done:

0%

Estimated time:
0.00 h
Actions #1

Updated by Peter Amstutz 7 months ago

  • Assigned To set to Lucas Di Pentima
Actions #2

Updated by Peter Amstutz 5 months ago

  • Assigned To changed from Lucas Di Pentima to Stephen Smith
Actions #3

Updated by Stephen Smith 4 months ago

  • Status changed from New to In Progress
Actions #4

Updated by Stephen Smith 4 months ago

Changes at arvados-workbench2|8b4f3ecb7f75b676fd027736605de02dc2602045 branch 19142-avoid-loading-unneeded-mounts
Tests developer-tests-workbench2: #833

Since the api lacks unselect, I looked into getting a list of fields for containers and container requests from the interface so I can dynamically remove mounts - it seems that's pretty hard to do (lack of reflection) (https://stackoverflow.com/questions/43909566/get-keys-of-a-typescript-interface-as-array-of-strings) so it seems the simplest solution is to list out the fields in an array.

Actions #5

Updated by Stephen Smith 4 months ago

Changes at arvados-workbench2|eb37d946f9aba8c06ad1b4c4d209943e9ec10ff8
Tests developer-tests-workbench2: #838

  • Added the same treatment to subprocess panel
Actions #6

Updated by Peter Amstutz 4 months ago

A couple of issues:

  1. Using the browser debug tools to check the behavior, I found that the "contents" API call that is done to fetch container requests is still getting "mounts".
    1. The follow-up request on "containers" correctly excludes mounts.
    2. Just filtering out mounts may run into the next problem
  2. The "all processes" seems to be correctly filtering out "mounts" however if you right-click and select "Inputs" (the old popup dialog) it crashes with "mounts is undefined"
    1. Navigating to the panel for that process seems to re-request the object, so then requesting "inputs" works correctly.
    2. I would be ok with removing the "Inputs" menu item for now since it is being replaced in the other branch.
Actions #7

Updated by Peter Amstutz 4 months ago

this is awkward.

The operative method is workbench2/src/store/project-panel/project-panel-middleware-service.ts:getParams()

It is a group contents call is retrieving multiple object types.

It appears that select isn't supported on the group contents call at all.

Actions #8

Updated by Stephen Smith 4 months ago

Changes at arvados-workbench2|34d812f41cb270711da12cd02313a88dcb85d3a4
Tests developer-tests-workbench2: #839

  • Removed inputs dialog from process context menu - it's still accessible from the process details panel
Actions #9

Updated by Peter Amstutz 4 months ago

Stephen Smith wrote in #note-8:

Changes at arvados-workbench2|34d812f41cb270711da12cd02313a88dcb85d3a4
Tests developer-tests-workbench2: #839

  • Removed inputs dialog from process context menu - it's still accessible from the process details panel

Thanks, LGTM

Actions #10

Updated by Stephen Smith 4 months ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF