Project

General

Profile

Actions

Bug #19143

open

Display 'Workflow' records in the Project listing

Added by Peter Amstutz about 1 month ago. Updated 7 days ago.

Status:
In Progress
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
05/20/2022
Due date:
% Done:

33%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Subtasks 3 (2 open1 closed)

Task #19151: Review 19143-project-list-workflowsResolvedPeter Amstutz05/20/2022

Actions
Task #19162: Add testsNewPeter Amstutz05/20/2022

Actions
Task #19174: Review tests branchNewLucas Di Pentima05/20/2022

Actions

Related issues

Related to Arvados - Story #16074: Design to revise browsing registered workflowsClosed

Actions
Related to Arvados - Bug #19069: launch workflow improvementsResolvedPeter Amstutz05/19/2022

Actions
Actions #1

Updated by Peter Amstutz about 1 month ago

  • Target version changed from 2022-05-25 sprint to 2022-06-08 sprint
Actions #2

Updated by Peter Amstutz about 1 month ago

  • Target version changed from 2022-06-08 sprint to 2022-05-25 sprint
Actions #3

Updated by Peter Amstutz about 1 month ago

  • Release set to 51
Actions #6

Updated by Peter Amstutz about 1 month ago

  • Assigned To set to Peter Amstutz
  • Status changed from New to In Progress
Actions #9

Updated by Peter Amstutz about 1 month ago

  • Target version changed from 2022-05-25 sprint to 2022-06-08 sprint
Actions #10

Updated by Peter Amstutz about 1 month ago

  • Related to Story #16074: Design to revise browsing registered workflows added
Actions #14

Updated by Lucas Di Pentima about 1 month ago

Just a couple comments:

  • Searching for workflows doesn't seem to work. Would this be a feature for another ticket?
  • At files cypress/integration/create-workflow.spec.js and cypress/integration/favorites.spec.js I suggest semantically tag the element being looked up for clicking with a "data-cy" prop so that this test doesn't fail when we reorder the workflow submission form.

Other than that, it LGTM.

Actions #15

Updated by Peter Amstutz about 1 month ago

  • Related to Bug #19069: launch workflow improvements added
Actions #16

Updated by Peter Amstutz about 1 month ago

Lucas Di Pentima wrote:

Just a couple comments:

  • Searching for workflows doesn't seem to work. Would this be a feature for another ticket?

You can filter the list from "Run a workflow", but I think you are talking about advanced search.

I started to add a ticket but then it occurred to me that if we migrate to storing Workflows as a special kind of collection as designed in #19132, then it'll show up in advanced search on its own.

  • At files cypress/integration/create-workflow.spec.js and cypress/integration/favorites.spec.js I suggest semantically tag the element being looked up for clicking with a "data-cy" prop so that this test doesn't fail when we reorder the workflow submission form.

I briefly tried this. This is complicated because these are generic components rendered in a generic form so I'm not sure where the data-cy attributes should go to be able to find them again. What it is doing right now is finding the label (with text "input") and then looking for the sibling control (which is the actual input field, coming immediately after the label). Unless we rearranged the rendering of the individual components themselves, it should be fairly stable.

Other than that, it LGTM.

Merged!

Actions #17

Updated by Peter Amstutz 21 days ago

  • Target version changed from 2022-06-08 sprint to 2022-06-22 Sprint
Actions #18

Updated by Peter Amstutz 7 days ago

  • Target version changed from 2022-06-22 Sprint to 2022-07-06
Actions

Also available in: Atom PDF