Arvados

19143-project-list-workflows @ arvados-workbench2|3c3d3d40033879249cd8e8f483f30cfa565d31bd

developer-tests-workbench2: #704

developer-tests-workbench2: #711

arvados-workbench2|4ff4d54006bc6c619616f6fc229b4374c5d83879

developer-tests-workbench2: #714

19143-project-list-workflows @ arvados-workbench2|d7f25e0db329c2fb8c2325f7ff28ce7a99cc2467

developer-tests-workbench2: #715

19143-project-list-workflows @ arvados-workbench2|1a49d9366053df6119bf855d3bfcbc5373744101

developer-tests-workbench2: #716

Just a couple comments:

• Searching for workflows doesn't seem to work. Would this be a feature for another ticket?
• At files cypress/integration/create-workflow.spec.js and cypress/integration/favorites.spec.js I suggest semantically tag the element being looked up for clicking with a "data-cy" prop so that this test doesn't fail when we reorder the workflow submission form.

Other than that, it LGTM.

Lucas Di Pentima wrote:

Just a couple comments:

• Searching for workflows doesn't seem to work. Would this be a feature for another ticket?

You can filter the list from "Run a workflow", but I think you are talking about advanced search.

I started to add a ticket but then it occurred to me that if we migrate to storing Workflows as a special kind of collection as designed in #19132, then it'll show up in advanced search on its own.

• At files cypress/integration/create-workflow.spec.js and cypress/integration/favorites.spec.js I suggest semantically tag the element being looked up for clicking with a "data-cy" prop so that this test doesn't fail when we reorder the workflow submission form.

I briefly tried this. This is complicated because these are generic components rendered in a generic form so I'm not sure where the data-cy attributes should go to be able to find them again. What it is doing right now is finding the label (with text "input") and then looking for the sibling control (which is the actual input field, coming immediately after the label). Unless we rearranged the rendering of the individual components themselves, it should be fairly stable.

Other than that, it LGTM.

Merged!