Project

General

Profile

Actions

Bug #19153

closed

Issues with opening and sharing links to files in collections

Added by Peter Amstutz about 1 month ago. Updated about 24 hours ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
06/22/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

  • link to /collections/uuid/filename
    • expected that it should open file, but just shows wb2 collection
  • .tsv files downloading instead of showing inline
There seems to be 2 issues:
  1. TSV files aren't interpreted as text files so they're downloaded even when directly clicking on them on the collection panel.
  2. Using the "Copy to clipboard" feature to get a https://example.com?redirectTo=/c=zzzzz-4zz18-zzzzzzzzzzzzz/somefile.jpg link makes the browser download the file instead of showing them inline, even if the file is correctly interpreted as images or text.

More detail:

User process is:

  1. User uses "copy URL" on a HTML file in a collection
  2. User sends URL to another person
  3. Person clicks on the URL
  4. Person logs into Arvados
  5. Person expects to see the HTML file rendered, but gets a download dialog instead

Also reported that clicking directly on HTML in file browser doesn't render it but also sends to download dialog.


Subtasks 1 (0 open1 closed)

Task #19185: Review 19153-sharing-links-inlineResolvedPeter Amstutz06/22/2022

Actions

Related issues

Related to Arvados - Bug #18171: cannot view HTMLs from arvados workbenchDuplicateLucas Di Pentima

Actions
Actions #1

Updated by Peter Amstutz about 1 month ago

  • Description updated (diff)
Actions #2

Updated by Peter Amstutz about 1 month ago

  • Target version changed from 2022-05-25 sprint to 2022-06-08 sprint
Actions #3

Updated by Peter Amstutz about 1 month ago

  • Assigned To set to Daniel Kutyła
Actions #4

Updated by Peter Amstutz 22 days ago

  • Target version changed from 2022-06-08 sprint to 2022-06-22 Sprint
Actions #5

Updated by Ward Vandewege 20 days ago

  • Related to Bug #18171: cannot view HTMLs from arvados workbench added
Actions #6

Updated by Lucas Di Pentima 19 days ago

  • Description updated (diff)
Actions #7

Updated by Peter Amstutz 9 days ago

  • Description updated (diff)
Actions #8

Updated by Peter Amstutz 9 days ago

  • Description updated (diff)
Actions #9

Updated by Peter Amstutz 9 days ago

  • Assigned To changed from Daniel Kutyła to Stephen Smith
Actions #10

Updated by Stephen Smith 8 days ago

Changes at arvados-workbench2|9876549a482c2c330143f5c9eebc8ab47cb8fa1d branch 19153-sharing-links-inline
Tests developer-tests-workbench2: #758

  • Added login redirect support for keep inline url
  • Generate inline redirect urls for clipboard actions

This brings the copy to clipboard behavior in line with the onclick behavior, but a separate fix is likely needed involving keep and mime types to work around browser behavior for tsv files.

Actions #11

Updated by Stephen Smith 8 days ago

  • Status changed from New to In Progress
Actions #12

Updated by Peter Amstutz 7 days ago

  • Target version changed from 2022-06-22 Sprint to 2022-07-06
Actions #13

Updated by Peter Amstutz 7 days ago

Stephen Smith wrote in #note-10:

Changes at arvados-workbench2|9876549a482c2c330143f5c9eebc8ab47cb8fa1d branch 19153-sharing-links-inline
Tests developer-tests-workbench2: #758

  • Added login redirect support for keep inline url
  • Generate inline redirect urls for clipboard actions

This brings the copy to clipboard behavior in line with the onclick behavior, but a separate fix is likely needed involving keep and mime types to work around browser behavior for tsv files.

This LGTM.

Actions #15

Updated by Stephen Smith 7 days ago

  • Status changed from In Progress to Resolved
Actions #16

Updated by Peter Amstutz 6 days ago

  • Release set to 52
Actions

Also available in: Atom PDF