Arvados

Ready for review at bed6d537db2e73cde17283d4f30117649ecce37f on branch 19164-add-flags

a) the common case is that we might be running packer from outside the cloud, so we need a public IP?

b) we enable ENA just because we're doing a lot of downloading so it's nice for it to be a bit faster?

The way the options are documented is a little confusing

--json-file (required)
Path to the packer json file

This is a path (it says so)

--aws-source-ami (default: false, required if building for AWS)
The AMI to use as base for building the images

The string is an AMI id but the default is false?

--aws-subnet-id
Subnet id for AWS otherwise packer will pick the default one for the VPC

This apparently has no default value except that it does

--nvidia-gpu-support (default: false)
Install all the necessary tooling for Nvidia GPU support

Doesn't actually accept 'false' as a value

Would be clearer written like this:

--json-file <file>
Path to the packer json file (required)

--aws-source-ami <ami-12345>
The AMI to use as base for building the images (required if building for AWS)

--aws-subnet-id <subnet id>
Subnet id for AWS, if not specified packer will pick the default one for the VPC

--nvidia-gpu-support
Install all the necessary tooling for Nvidia GPU support (default: do not install Nvidia GPU support)

Peter Amstutz wrote:

a) the common case is that we might be running packer from outside the cloud, so we need a public IP?

Yes. Or from another VPC that doesn't route directly to the destination VPC.

b) we enable ENA just because we're doing a lot of downloading so it's nice for it to be a bit faster?

No, because it's the default and it is what you are supposed to have on. But if you are in a weird AWS environment with really old node types, apparently you sometimes want to turn it off.

The way the options are documented is a little confusing

--json-file (required)
Path to the packer json file

This is a path (it says so)

--aws-source-ami (default: false, required if building for AWS)
The AMI to use as base for building the images

The string is an AMI id but the default is false?

--aws-subnet-id
Subnet id for AWS otherwise packer will pick the default one for the VPC

This apparently has no default value except that it does

--nvidia-gpu-support (default: false)
Install all the necessary tooling for Nvidia GPU support

Doesn't actually accept 'false' as a value

Would be clearer written like this:

--json-file <file>
Path to the packer json file (required)

--aws-source-ami <ami-12345>
The AMI to use as base for building the images (required if building for AWS)

--aws-subnet-id <subnet id>
Subnet id for AWS, if not specified packer will pick the default one for the VPC

--nvidia-gpu-support
Install all the necessary tooling for Nvidia GPU support (default: do not install Nvidia GPU support)

I've reworked the help text for all the options along those lines in 6c0603da8c198c069bf285bba51a0fd0e39bea72 on branch 19164-add-flags.