Project

General

Profile

Actions

Feature #19164

closed

[compute image builder] [AWS} add flag for public IP association

Added by Ward Vandewege 3 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
05/25/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Add a flag that can be used to disable the association of a public IP address for the node that Packer uses to build a new images, when building on AWS. A public IP is not needed when that node is reachable via the internal IP, and in some environments public IPs are not allowed by policy.

The option should default to "true": in the common case a public IP is desired.

Likewise, add a flag for ENA support. In some environments this feature is not available. Default it to "true".


Subtasks 1 (0 open1 closed)

Task #19165: review 19164-add-flagsResolvedPeter Amstutz05/25/2022

Actions
Actions #1

Updated by Ward Vandewege 3 months ago

  • Status changed from New to In Progress
Actions #2

Updated by Ward Vandewege 3 months ago

  • Description updated (diff)
Actions #3

Updated by Ward Vandewege 3 months ago

  • Description updated (diff)
  • Subject changed from [compute image builder] [AWS} add option to disable public IP association to [compute image builder] [AWS} add flag for public IP association
Actions #4

Updated by Ward Vandewege 3 months ago

Ready for review at bed6d537db2e73cde17283d4f30117649ecce37f on branch 19164-add-flags

Actions #5

Updated by Peter Amstutz 3 months ago

a) the common case is that we might be running packer from outside the cloud, so we need a public IP?

b) we enable ENA just because we're doing a lot of downloading so it's nice for it to be a bit faster?

The way the options are documented is a little confusing

--json-file (required)
Path to the packer json file

This is a path (it says so)

--aws-source-ami (default: false, required if building for AWS)
The AMI to use as base for building the images

The string is an AMI id but the default is false?

--aws-subnet-id
Subnet id for AWS otherwise packer will pick the default one for the VPC

This apparently has no default value except that it does

--nvidia-gpu-support (default: false)
Install all the necessary tooling for Nvidia GPU support

Doesn't actually accept 'false' as a value

Would be clearer written like this:

--json-file <file>
Path to the packer json file (required)

--aws-source-ami <ami-12345>
The AMI to use as base for building the images (required if building for AWS)

--aws-subnet-id <subnet id>
Subnet id for AWS, if not specified packer will pick the default one for the VPC

--nvidia-gpu-support
Install all the necessary tooling for Nvidia GPU support (default: do not install Nvidia GPU support)

Actions #6

Updated by Ward Vandewege 2 months ago

Peter Amstutz wrote:

a) the common case is that we might be running packer from outside the cloud, so we need a public IP?

Yes. Or from another VPC that doesn't route directly to the destination VPC.

b) we enable ENA just because we're doing a lot of downloading so it's nice for it to be a bit faster?

No, because it's the default and it is what you are supposed to have on. But if you are in a weird AWS environment with really old node types, apparently you sometimes want to turn it off.

The way the options are documented is a little confusing

--json-file (required)
Path to the packer json file

This is a path (it says so)

--aws-source-ami (default: false, required if building for AWS)
The AMI to use as base for building the images

The string is an AMI id but the default is false?

--aws-subnet-id
Subnet id for AWS otherwise packer will pick the default one for the VPC

This apparently has no default value except that it does

--nvidia-gpu-support (default: false)
Install all the necessary tooling for Nvidia GPU support

Doesn't actually accept 'false' as a value

Would be clearer written like this:

--json-file <file>
Path to the packer json file (required)

--aws-source-ami <ami-12345>
The AMI to use as base for building the images (required if building for AWS)

--aws-subnet-id <subnet id>
Subnet id for AWS, if not specified packer will pick the default one for the VPC

--nvidia-gpu-support
Install all the necessary tooling for Nvidia GPU support (default: do not install Nvidia GPU support)

I've reworked the help text for all the options along those lines in 6c0603da8c198c069bf285bba51a0fd0e39bea72 on branch 19164-add-flags.

Actions #7

Updated by Ward Vandewege 2 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved

Applied in changeset arvados-private:commit:arvados|f3cb43d4be379703a965a1cb14cae5f5c855728f.

Actions #8

Updated by Lucas Di Pentima 2 months ago

  • Release set to 51
Actions

Also available in: Atom PDF