Project

General

Profile

Actions

Feature #19177

closed

Config option to disable sharing links

Added by Peter Amstutz 4 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
06/09/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Requested by customer -- sharing links violate their internal data management policy, so they would prefer an option to disable the UI create sharing links (sharing links tab on wb2).

Should do the same on wb1.


Subtasks 1 (0 open1 closed)

Task #19183: Review 19177-sharing-links-ui-config (arvados repo) & 19177-sharing-urls-ui-config (wb2 repo)ResolvedPeter Amstutz06/09/2022

Actions
Actions #1

Updated by Peter Amstutz 4 months ago

  • Description updated (diff)
Actions #2

Updated by Peter Amstutz 4 months ago

  • Description updated (diff)
Actions #3

Updated by Lucas Di Pentima 4 months ago

  • Assigned To set to Lucas Di Pentima
  • Status changed from New to In Progress
Actions #4

Updated by Lucas Di Pentima 4 months ago

Updates at 2ed8d670a - branch 19177-sharing-links-ui-config

  • Adds an exported boolean config knob at Workbench.DisableSharingURLsUI in controller (false by default)
  • Makes Workbench1 not show the Share/Unshare button & links when this config is set to true.
  • Adds test.

Tests are failing (developer-run-tests: #3168 ), but not yet sure if it is because of these changes.

Actions #5

Updated by Lucas Di Pentima 4 months ago

Updates at arvados-workbench2|e1e17729 - branch 19177-sharing-urls-ui-config
Test run: developer-tests-workbench2: #741

  • Reads Workbench.DisableSharingURLsUI config from controller and hides the "Sharing URLs" tab on the collection's sharing dialog if needed.
  • Also avoids making unnecessary requests for scoped tokens if Workbench.DisableSharingURLsUI is true.
  • Adds unit tests.
Actions #6

Updated by Lucas Di Pentima 4 months ago

Updates at d104886 (arvados repo)
Test run: developer-run-tests: #3170
Failed test re-run: developer-run-tests-apps-workbench-integration: #3398

  • Fixes wb1's test assertions when checking for the "Create sharing link" button.

For Workbench2's tests, I had to run them against arvados' 40e378c commit, it seems there's some kind of issue on our Jenkins pipeline that causes the arvados-server run to fail after ~20 minutes when run against the current main.
Test run: developer-tests-workbench2: #744

Actions #7

Updated by Peter Amstutz 4 months ago

Lucas Di Pentima wrote:

Updates at d104886 (arvados repo)
Test run: developer-run-tests: #3170
Failed test re-run: developer-run-tests-apps-workbench-integration: #3398

  • Fixes wb1's test assertions when checking for the "Create sharing link" button.

For Workbench2's tests, I had to run them against arvados' 40e378c commit, it seems there's some kind of issue on our Jenkins pipeline that causes the arvados-server run to fail after ~20 minutes when run against the current main.
Test run: developer-tests-workbench2: #744

By only comment is that it's clearer for configuration items to enable things than to disable things, so "EnableSharingURLsUI" with default "true" is less confusing than having to set "true" to disable it. Although maybe there is a counter-argument is that it is better for "false" value to mean you want default behavior.

However either way I don't think it is worth going back and changing it, so this LGTM.

Actions #8

Updated by Lucas Di Pentima 4 months ago

  • Status changed from In Progress to Resolved
Actions #9

Updated by Peter Amstutz about 2 months ago

  • Release set to 52
Actions

Also available in: Atom PDF