https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422022-06-03T14:02:17ZArvadosArvados - Feature #19177: Config option to disable sharing linkshttps://dev.arvados.org/issues/19177?journal_id=1041292022-06-03T14:02:17ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/104129/diff?detail_id=100720">diff</a>)</li></ul> Arvados - Feature #19177: Config option to disable sharing linkshttps://dev.arvados.org/issues/19177?journal_id=1041402022-06-03T16:15:12ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/104140/diff?detail_id=100730">diff</a>)</li></ul> Arvados - Feature #19177: Config option to disable sharing linkshttps://dev.arvados.org/issues/19177?journal_id=1042172022-06-08T11:02:38ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Lucas Di Pentima</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Feature #19177: Config option to disable sharing linkshttps://dev.arvados.org/issues/19177?journal_id=1042462022-06-08T15:22:39ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Updates at <a class="changeset" title="19177: Adds test to wb1 for sharing link button hideability. Arvados-DCO-1.1-Signed-off-by: Luca..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/2ed8d670a5d6f93eed57cb14138323cc835e027f">2ed8d670a</a> - branch <code>19177-sharing-links-ui-config</code></p>
<ul>
<li>Adds an exported boolean config knob at <code>Workbench.DisableSharingURLsUI</code> in <code>controller</code> (<code>false</code> by default)</li>
<li>Makes Workbench1 not show the Share/Unshare button & links when this config is set to <code>true</code>.</li>
<li>Adds test.</li>
</ul>
<p>Tests are failing (<a class="external" href="https://ci.arvados.org/job/developer-run-tests/3168/"<a href="https://ci.arvados.org/job/developer-run-tests/3168/">developer-run-tests: #3168 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=3168" alt="" /></a></a>), but not yet sure if it is because of these changes.</p> Arvados - Feature #19177: Config option to disable sharing linkshttps://dev.arvados.org/issues/19177?journal_id=1042732022-06-08T18:48:17ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Updates at <a class="changeset" title="19177: Hides 'Sharing URLs' tab from Sharing dialog when configured to do so. Also, adds some un..." href="https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/e1e17729d024637f9f3392611c9a59dc31e5db23">arvados-workbench2|e1e17729</a> - branch <code>19177-sharing-urls-ui-config</code><br />Test run: <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/741/"<a href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/741/">developer-tests-workbench2: #741 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=741" alt="" /></a></a></p>
<ul>
<li>Reads <code>Workbench.DisableSharingURLsUI</code> config from <code>controller</code> and hides the "Sharing URLs" tab on the collection's sharing dialog if needed.</li>
<li>Also avoids making unnecessary requests for scoped tokens if <code>Workbench.DisableSharingURLsUI</code> is <code>true</code>.</li>
<li>Adds unit tests.</li>
</ul> Arvados - Feature #19177: Config option to disable sharing linkshttps://dev.arvados.org/issues/19177?journal_id=1042752022-06-08T19:05:10ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Updates at <a class="changeset" title="19177: Fixes tests. Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima@curii.com>" href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/d104886f95ab9bf0712873c809410b34f8bed031">d104886</a> (arvados repo)<br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-run-tests/3170/"<a href="https://ci.arvados.org/job/developer-run-tests/3170/">developer-run-tests: #3170 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=3170" alt="" /></a></a><br />Failed test re-run: <a class="external" href="https://ci.arvados.org/job/developer-run-tests-apps-workbench-integration/3398/"<a href="https://ci.arvados.org/job/developer-run-tests-apps-workbench-integration/3398/">developer-run-tests-apps-workbench-integration: #3398 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests-apps-workbench-integration&build=3398" alt="" /></a></a></p>
<ul>
<li>Fixes wb1's test assertions when checking for the "Create sharing link" button.</li>
</ul>
<p>For Workbench2's tests, I had to run them against arvados' <a class="changeset" title="Fix 2.4.1 release date refs #19017 Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@c..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/40e378c88c2ae8e90b0785f3983ca320827e4cdf">40e378c</a> commit, it seems there's some kind of issue on our Jenkins pipeline that causes the <code>arvados-server</code> run to fail after ~20 minutes when run against the current <code>main</code>.<br />Test run: <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/744/"<a href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/744/">developer-tests-workbench2: #744 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=744" alt="" /></a></a></p> Arvados - Feature #19177: Config option to disable sharing linkshttps://dev.arvados.org/issues/19177?journal_id=1042942022-06-10T14:37:17ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Lucas Di Pentima wrote:</p>
<blockquote>
<p>Updates at <a class="changeset" title="19177: Fixes tests. Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima@curii.com>" href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/d104886f95ab9bf0712873c809410b34f8bed031">d104886</a> (arvados repo)<br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-run-tests/3170/"<a href="https://ci.arvados.org/job/developer-run-tests/3170/">developer-run-tests: #3170 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=3170" alt="" /></a></a><br />Failed test re-run: <a class="external" href="https://ci.arvados.org/job/developer-run-tests-apps-workbench-integration/3398/"<a href="https://ci.arvados.org/job/developer-run-tests-apps-workbench-integration/3398/">developer-run-tests-apps-workbench-integration: #3398 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests-apps-workbench-integration&build=3398" alt="" /></a></a></p>
<ul>
<li>Fixes wb1's test assertions when checking for the "Create sharing link" button.</li>
</ul>
<p>For Workbench2's tests, I had to run them against arvados' <a class="changeset" title="Fix 2.4.1 release date refs #19017 Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@c..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/40e378c88c2ae8e90b0785f3983ca320827e4cdf">40e378c</a> commit, it seems there's some kind of issue on our Jenkins pipeline that causes the <code>arvados-server</code> run to fail after ~20 minutes when run against the current <code>main</code>.<br />Test run: <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/744/"<a href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/744/">developer-tests-workbench2: #744 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=744" alt="" /></a></a></p>
</blockquote>
<p>By only comment is that it's clearer for configuration items to enable things than to disable things, so "EnableSharingURLsUI" with default "true" is less confusing than having to set "true" to disable it. Although maybe there is a counter-argument is that it is better for "false" value to mean you want default behavior.</p>
<p>However either way I don't think it is worth going back and changing it, so this LGTM.</p> Arvados - Feature #19177: Config option to disable sharing linkshttps://dev.arvados.org/issues/19177?journal_id=1042972022-06-10T15:46:09ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset <a class="changeset" title="Merge branch '19177-sharing-urls-ui-config'. Closes #19177 Arvados-DCO-1.1-Signed-off-by: Lucas ..." href="https://dev.arvados.org/projects/arvados-workbench-2/repository/arvados-workbench2/revisions/7b94876543bd53cf2ab676e3f6dab0f9e4fffd3f">arvados-workbench-2:arvados-workbench2|7b94876543bd53cf2ab676e3f6dab0f9e4fffd3f</a>.</p> Arvados - Feature #19177: Config option to disable sharing linkshttps://dev.arvados.org/issues/19177?journal_id=1052612022-08-03T20:09:08ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>52</i></li></ul>