Project

General

Profile

Actions
Copy link

Bug #19273

closed

Searching for processes shows them all as "Cancelled"

Added by Peter Amstutz 8 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Stephen Smith
Category:
Workbench2
Target version:
2023-02-15 sprint
Start date:
01/27/2023
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
2.0

Description

If you search for a process (e.g. by title) it does not seem to load the status correctly, and they all show as "Cancelled".

Subtasks 1 (0 open — 1 closed)

Task #19947: Review 19273-process-status-badgeResolvedStephen Smith01/27/2023

Actions

Related issues

Related to Arvados - Bug #19971: Shows "Cancelled" when state is unknown, not loading all the states for subprocessesNew

Actions
Actions
Copy link
 #1

Updated by Peter Amstutz 8 months ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Peter Amstutz 8 months ago

  • Target version changed from 2022-08-03 Sprint to 2022-08-17 sprint
Actions
Copy link
 #3

Updated by Peter Amstutz 8 months ago

  • Target version changed from 2022-08-17 sprint to 2022-08-31 sprint
Actions
Copy link
 #4

Updated by Peter Amstutz 7 months ago

  • Target version changed from 2022-08-31 sprint to 2022-09-14 sprint
Actions
Copy link
 #5

Updated by Peter Amstutz 7 months ago

  • Target version changed from 2022-09-14 sprint to 2022-09-28 sprint
Actions
Copy link
 #6

Updated by Peter Amstutz 6 months ago

  • Target version changed from 2022-09-28 sprint to 2022-10-12 sprint
Actions
Copy link
 #7

Updated by Peter Amstutz 6 months ago

  • Target version changed from 2022-10-12 sprint to 2022-10-26 sprint
Actions
Copy link
 #8

Updated by Peter Amstutz 5 months ago

  • Target version changed from 2022-10-26 sprint to 2022-11-09 sprint
Actions
Copy link
 #9

Updated by Peter Amstutz 5 months ago

  • Target version changed from 2022-11-09 sprint to 2022-11-23 sprint
Actions
Copy link
 #10

Updated by Peter Amstutz 5 months ago

  • Target version changed from 2022-11-23 sprint to 2022-12-07 Sprint
Actions
Copy link
 #11

Updated by Peter Amstutz 4 months ago

  • Target version changed from 2022-12-07 Sprint to 2022-12-21 Sprint
Actions
Copy link
 #12

Updated by Stephen Smith 4 months ago

  • Story points set to 2.0
Actions
Copy link
 #13

Updated by Peter Amstutz 3 months ago

  • Target version changed from 2022-12-21 Sprint to 2023-01-18 sprint
Actions
Copy link
 #14

Updated by Peter Amstutz 3 months ago

  • Target version changed from 2023-01-18 sprint to 2023-02-01 sprint
Actions
Copy link
 #15

Updated by Peter Amstutz 3 months ago

  • Target version changed from 2023-02-01 sprint to 2023-01-18 sprint
Actions
Copy link
 #16

Updated by Stephen Smith 3 months ago

  • Assigned To set to Stephen Smith
Actions
Copy link
 #17

Updated by Stephen Smith 2 months ago

  • Status changed from New to In Progress
Actions
Copy link
 #18

Updated by Peter Amstutz 2 months ago

  • Target version changed from 2023-01-18 sprint to 2023-02-01 sprint
Actions
Copy link
 #19

Updated by Peter Amstutz about 2 months ago

  • Related to Bug #19971: Shows "Cancelled" when state is unknown, not loading all the states for subprocesses added
Actions
Copy link
 #20

Updated by Stephen Smith about 2 months ago

Changes at arvados-workbench2|8aad39537a5998cc11038e9a96f9424d46aa7443
Tests developer-tests-workbench2: #1064

  • Add case to display unknown process status badge when container details haven't loaded yet
  • Fix list queries not mapping keys to camelcase when showErrors = false (misalignment of method parameters)
  • Request container details on search results page for process status badge to work
Actions
Copy link
 #21

Updated by Peter Amstutz about 2 months ago

  • Target version changed from 2023-02-01 sprint to 2023-02-15 sprint
Actions
Copy link
 #22

Updated by Lucas Di Pentima about 2 months ago

Just one suggestion:

  • Would it be convenient to check if containerRequests is not empty before making the list call at src/store/search-results-panel/search-results-middleware-service.ts line 67? I'm thinking the case when a user does a search which results in zero CRs, we could be saving time by not doing those calls, especially on a federated scenario (testing on tordo, it made 3 useless calls, ~600ms each)

With that, it LGTM

Actions
Copy link
 #23

Updated by Stephen Smith about 2 months ago

Changes at arvados-workbench2|fe6be4c404720670989f96784db9f87f8ac86b76
Tests developer-tests-workbench2: #1067

  • Avoid making empty queries for containers when no container requests in search results
Actions
Copy link
 #24

Updated by Stephen Smith about 2 months ago

  • Status changed from In Progress to Resolved
Actions
Copy link

Also available in: Atom PDF