Project

General

Profile

Actions

Bug #19280

closed

Slow workflow startup time when entire workflow is defined in a single file

Added by Peter Amstutz 29 days ago. Updated 14 days ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
CWL
Target version:
Start date:
08/04/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Subtasks 1 (0 open1 closed)

Task #19290: Review 19280-cache-loadrefResolvedPeter Amstutz08/04/2022

Actions
Actions #1

Updated by Peter Amstutz 29 days ago

  • Status changed from New to In Progress
Actions #2

Updated by Peter Amstutz 28 days ago

  • Target version changed from 2022-07-20 to 2022-08-03 Sprint
Actions #3

Updated by Peter Amstutz 15 days ago

  • Target version changed from 2022-08-03 Sprint to 2022-08-17 sprint
Actions #4

Updated by Peter Amstutz 14 days ago

19280-cache-loadref @ 3fb6110248db3f87fb21f852c8d6bfebbb2910a0

  • When scanning for dependencies, keep a cache of files that have already been loaded/parsed, so that when there's one big file we don't keep re-parsing it
  • Pull in performance fix from schema-salad (https://github.com/common-workflow-language/schema_salad/releases/tag/8.3.20220801194920) by caching the "metaschema" instead of redundantly reloading it
  • Disable validation when re-loading the original version of the document (since it already passed validation)
  • Fix install problem with msgpack
  • Fix for 1.2.1 conformance test "tests/secondaryfiles/rename-inputs.cwl"
  • Tested locally against 1.2.1 conformance tests, everything expected to pass, passes

developer-run-tests: #3258

Actions #5

Updated by Peter Amstutz 14 days ago

  • Release set to 52
Actions #6

Updated by Tom Clegg 14 days ago

LGTM, thanks

Actions #7

Updated by Peter Amstutz 14 days ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF