Bug #19281
closed
diagnostics should default to an embedded hello-world docker image
Description
The diagnostics run a test container to verify that crunch is working. However, it assumes that an alpine image (or a different image specified on the command line, perhaps arvados/jobs:latest) has been loaded. Our install process doesn't load any images, because arvados-cwl-runner is responsible for loading the image that corresponds to the exact version of a-c-r being used, on demand.
Running the "/hello" command with the "hello-world" image would work just as well, and that image is only ~20KB.
The diagnostics command should embed the hello-world image, and upload it to Keep at runtime, instead of relying on the docker daemon being installed/working on the client host.
Continue to support the -docker-image=... option as well (assume the image is already uploaded).
Requested command should be /hello if using the hello-world image, otherwise echo {timestamp}.
Updated by Peter Amstutz over 2 years ago
- Target version changed from 2022-07-20 to 2022-08-03 Sprint
Updated by Tom Clegg over 2 years ago
- Assigned To set to Tom Clegg
- Description updated (diff)
- Subject changed from Diagnostics should be able to load arvados/jobs:latest or give useful instructions on how to do so to diagnostics should default to an embedded hello-world docker image
Updated by Tom Clegg over 2 years ago
- Status changed from New to In Progress
19281-diagnostics-image @ 32b402114038bc6761c04c370afad786dbbb3125 -- developer-run-tests: #3244
(only wb1 failed as usual)
Defaults to "hello world" image (which is now uploaded as the "upload test" data) + "/hello" cmd, but if a different image is provided on the command line, the command is "echo {timestamp}" as before.
Updated by Lucas Di Pentima over 2 years ago
- If we already support running containers on our integration tests, I think it would be convenient to add one for this, to detect potential image format incompatibilities in the future.
- Otherwise, it LGTM.
Updated by Tom Clegg over 2 years ago
Good point. Added test in lib/crunchrun to confirm it works in both docker and singularity.
19281-diagnostics-image @ 711d8642c478c29ffd4c9bc6facbf3bd4d168763 -- developer-run-tests: #3247
Updated by Tom Clegg over 2 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados-private:commit:arvados|62612ee23efe146829a7bb64817cdd23f41775bb.