Arvados

19295-reused @ 756da23ade34fd225e80e448fb27795d453294c6

• Show "Reused" process state when container.finished_at < container_request.created_at

I didn't compare on createdAt because the container can have a slightly earlier creation time when it is created in the same transaction as the container request. I chose to use finishedAt because most people will assume "reused" means no additional work needed to be done, so while it's possible to share a running container, calling it "reused" in that case is more likely to be confusing.

developer-tests-workbench2: #1173

Some comments:

• There're many compiler warnings that probably come from the previously merged branch that would be nice to fix.
• The update works OK but as it is, it creates a disconnect between all the available Status and the status filtering capabilities.
  • It may be confusing to the user to request listing only Completed process and reading another label.
  • They may even they want to only list the reused processes, to quickly assess how much work Arvados saves them.

Other than that, it LGTM.

from review discussion, should also have a "cancelling" state when it is priority=0 but still running.

The way the filter dropdown is set up, changing it to say "Completed and Reused" is actually sort of complicated, so I choose not to do it. We can revisit it if there is feedback about it.

We don't have a way purely with an API query to filter on reused/not reused processes.

I made a few other changes:

• Added "Cancelling" state for when the cancel button has been pushed (priority=0) but it is still running
• Tweaked the styling of the cancel button
• Tweaked the "Type" filter to reflect the relative ordering of workflow runs vs workflow definitions (the group contents API returns workflow definitions after workflow runs, unfortunately)
• Made intermediate and log collections hidden by default (this greatly reduces the clutter in the default view).

I verbally discussed these changes with the team, and since they are fairly low-risk changes I went ahead and merged this.