Project

General

Profile

Actions

Bug #19305

closed

"Edit project" dialog doesn't show existing properties when invoked from breadcrumbs

Added by Lucas Di Pentima 2 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Start date:
08/02/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

The result from this bug is that a user loses previously set properties when invoking the edit dialog and saving some change.


Subtasks 1 (0 open1 closed)

Task #19309: Review 19305-project-update-dialog-propertiesResolvedStephen Smith08/02/2022

Actions
Actions #1

Updated by Peter Amstutz about 2 months ago

  • Target version changed from 2022-08-17 sprint to 2022-08-03 Sprint
  • Assigned To set to Stephen Smith
Actions #2

Updated by Stephen Smith about 2 months ago

  • Status changed from New to In Progress

Changes at arvados-workbench2|5d7bd1113f9decfb87d002954f6c11e0bfc53d04 branch 19305-project-update-dialog-properties
Tests developer-tests-workbench2: #830

  • Changed open update project dialog action to fetch project from store instead of using the passed in resource which is incomplete when coming from breadcrumbs
Actions #3

Updated by Lucas Di Pentima about 2 months ago

Just one request:

Could you add/expand a cypress test to confirm that the dialog is showing all the existing properties when invoked from the bradcrumbs? (I think we already have a handy data-cy selector for breadcrumbs that you could use).

Actions #4

Updated by Stephen Smith about 2 months ago

Changes at arvados-workbench2|779c11eec0987729b1be87f9f2e9f578c7b6c0a7
Tests developer-tests-workbench2: #831

  • added test to view existing properties and add new properties via breadcrumbs edit option
Actions #5

Updated by Lucas Di Pentima about 2 months ago

This LGTM, thanks!

Actions #6

Updated by Stephen Smith about 2 months ago

  • Status changed from In Progress to Resolved
Actions #7

Updated by Peter Amstutz about 2 months ago

  • Release set to 52
Actions

Also available in: Atom PDF