Project

General

Profile

Actions

Bug #19307

open

Directly shared collection with write permission cannot be modified

Added by Lucas Di Pentima over 2 years ago. Updated almost 2 years ago.

Status:
New
Priority:
Normal
Assigned To:
-
Category:
Workbench2
Target version:
Story points:
1.0

Description

If user A shares a collection with user B giving B write permissions to it, when B accesses the collection, the "broken pencil" icon appears beside the collection's name, and the UI only allows reading operations.
This doesn't happen when a collection is shared via its parent group being shared with write permissions.

Further testing results

This is not an issue specific to Workbench2, but a shared problem between the 2 workbenches: they don't seem to care about links set directly to a collection, and I may have found a related permission issue from the API:

  • Collection C inside Project P. P is shared can_write with user B, but C is shared with can_read with this same user. The result: User B can edit collection C. This doesn't seem right.
  • Collection C from user A's home project is shared with can_write with user B: both workbenches show C as read-only, but user B can edit the collection using the CLI tools.

I believe more discussion is needed to properly decide which fixes we're going to apply. If we are going to make Workbench2 misbehave the same way as Workbench1, then the "fix" would be to remove the "Share" option on collections. This may be a 1 or 2 point story.
If properly fixing the issue requires revising RailsAPI's permission or other parts so that it adds a writable_by field to collections, that will probably be a bigger story.


Subtasks 1 (1 open0 closed)

Arvados - Task #19397: ReviewNewPeter AmstutzActions
Actions #1

Updated by Peter Amstutz over 2 years ago

  • Target version changed from 2022-08-17 sprint to 2022-08-03 Sprint
  • Assigned To set to Stephen Smith
Actions #2

Updated by Peter Amstutz over 2 years ago

Need to check on this after the frozen projects branch is merged.

Actions #3

Updated by Peter Amstutz over 2 years ago

  • Assigned To changed from Stephen Smith to Daniel Kutyła
Actions #4

Updated by Peter Amstutz over 2 years ago

  • Target version changed from 2022-08-03 Sprint to 2022-08-17 sprint
Actions #5

Updated by Peter Amstutz over 2 years ago

  • Target version changed from 2022-08-17 sprint to 2022-08-31 sprint
Actions #6

Updated by Peter Amstutz over 2 years ago

  • Target version changed from 2022-08-31 sprint to 2022-09-14 sprint
Actions #7

Updated by Peter Amstutz over 2 years ago

  • Target version changed from 2022-09-14 sprint to 2022-09-28 sprint
Actions #8

Updated by Peter Amstutz over 2 years ago

  • Target version changed from 2022-09-28 sprint to 2022-10-12 sprint
Actions #9

Updated by Peter Amstutz about 2 years ago

  • Target version changed from 2022-10-12 sprint to 2022-10-26 sprint
Actions #10

Updated by Peter Amstutz about 2 years ago

  • Target version changed from 2022-10-26 sprint to 2022-11-09 sprint
Actions #11

Updated by Peter Amstutz about 2 years ago

  • Target version changed from 2022-11-09 sprint to 2022-11-23 sprint
Actions #12

Updated by Peter Amstutz about 2 years ago

  • Target version changed from 2022-11-23 sprint to 2022-12-07 Sprint
Actions #13

Updated by Peter Amstutz about 2 years ago

  • Target version changed from 2022-12-07 Sprint to 2022-12-21 Sprint
Actions #14

Updated by Peter Amstutz about 2 years ago

  • Target version changed from 2022-12-21 Sprint to 2023-01-18 sprint
Actions #15

Updated by Peter Amstutz about 2 years ago

  • Target version changed from 2023-01-18 sprint to 2023-02-01 sprint
Actions #16

Updated by Peter Amstutz about 2 years ago

  • Target version changed from 2023-02-01 sprint to 2023-02-15 sprint
Actions #17

Updated by Peter Amstutz about 2 years ago

  • Target version changed from 2023-02-15 sprint to 2023-03-01 sprint
Actions #18

Updated by Peter Amstutz almost 2 years ago

  • Target version changed from 2023-03-01 sprint to Future
Actions #19

Updated by Peter Amstutz almost 2 years ago

  • Assigned To deleted (Daniel Kutyła)
Actions #20

Updated by Peter Amstutz almost 2 years ago

  • Assigned To set to Lucas Di Pentima
Actions #21

Updated by Lucas Di Pentima almost 2 years ago

  • Status changed from New to Feedback
  • Description updated (diff)
Actions #22

Updated by Lucas Di Pentima almost 2 years ago

From grooming meeting: The permission behavior observed here is correct, and Workbench should warn the user that permissions from the collection's parent project might take precendence over the individual collection's permissions.

Actions #23

Updated by Lucas Di Pentima almost 2 years ago

  • Story points set to 1.0
Actions #24

Updated by Lucas Di Pentima almost 2 years ago

  • Assigned To deleted (Lucas Di Pentima)
  • Status changed from Feedback to New
Actions

Also available in: Atom PDF