https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422022-08-02T17:39:17ZArvadosArvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1051092022-08-02T17:39:17ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>I've also seen this misbehavior on the Users UI's search field.</p> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1051652022-08-03T15:46:57ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2022-08-17 sprint</i> to <i>2022-08-31 sprint</i></li></ul> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1051672022-08-03T15:47:05ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2022-08-31 sprint</i> to <i>2022-08-17 sprint</i></li></ul> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1052152022-08-03T17:55:56ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Stephen Smith</i></li><li><strong>Category</strong> set to <i>Workbench2</i></li></ul> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1052252022-08-03T18:00:27ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Assigned To</strong> changed from <i>Stephen Smith</i> to <i>Daniel Kutyła</i></li></ul> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1052542022-08-03T20:04:04ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> deleted (<del><i>52</i></del>)</li></ul> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1057362022-08-17T15:14:17ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2022-08-17 sprint</i> to <i>2022-08-31 sprint</i></li></ul> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1059392022-08-31T17:50:06ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2022-08-31 sprint</i> to <i>2022-09-14 sprint</i></li></ul> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1059562022-08-31T19:42:58ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2022-09-14 sprint</i> to <i>2022-09-28 sprint</i></li></ul> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1062822022-09-13T18:12:24ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2022-09-28 sprint</i> to <i>2022-10-12 sprint</i></li></ul> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1067182022-09-27T18:54:40ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2022-10-12 sprint</i> to <i>2022-10-26 sprint</i></li></ul> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1069362022-10-05T17:31:00ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2022-10-26 sprint</i> to <i>2022-10-12 sprint</i></li></ul> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1069752022-10-06T18:31:24ZDaniel Kutyła
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1070592022-10-11T18:57:22ZDaniel Kutyła
<ul></ul><p>New version: <a class="external" href="https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/235d9456eb6679611af96383f9dfcadc3462a7da">https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/235d9456eb6679611af96383f9dfcadc3462a7da</a><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-tests-workbench2/953/"<a href="https://ci.arvados.org/job/developer-tests-workbench2/953/">developer-tests-workbench2: #953 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=953" alt="" /></a></a><br />Branch: 19311-Project-Search-field-auto-clears</p>
<p>Added inital check before search field clear</p> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1070642022-10-12T13:35:09ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><ul>
<li>The reported issue on the projects view seems to be working well now, thanks.</li>
<li>OTOH, I've checked how the search input behaves on the collection's file browser and the previous problematic behavior persists. (try a collection with a subdirectory so that the search input is in both panels of the file browser)</li>
<li>I'm worried about that global <code>selfClearPropState</code> variable that was added at <code>src/components/search-input/search-input.tsx</code>, I'm thinking that it could create issues difficult to debug, can you make the component's state completely isolated? If more than one instance of the component is in use, that global would be a shared state between both input fields, and that's not what we want, right?</li>
</ul> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1070712022-10-12T15:11:20ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2022-10-12 sprint</i> to <i>2022-10-26 sprint</i></li></ul> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1071902022-10-17T20:12:40ZDaniel Kutyła
<ul></ul><p>New version: <a class="external" href="https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/e4f350462118a86831f92eb375c2bc89cbf85920">https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/e4f350462118a86831f92eb375c2bc89cbf85920</a><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-tests-workbench2/962/"<a href="https://ci.arvados.org/job/developer-tests-workbench2/962/">developer-tests-workbench2: #962 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=962" alt="" /></a></a><br />Branch: 19311-Project-Search-field-auto-clears</p>
<p>Changed component type to a functional approach</p> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1071932022-10-17T21:06:37ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Commit <a class="changeset" title="Merge remote-tracking branch 'origin/main' into 19311-Project-Search-field-auto-clears Arvados-D..." href="https://dev.arvados.org/projects/arvados-workbench-2/repository/arvados-workbench2/revisions/e4f350462118a86831f92eb375c2bc89cbf85920">arvados-workbench2|e4f3504</a> seems to be just a <code>main</code> merge, are you sure all the pending work was checked in and pushed?</p> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1071962022-10-18T15:29:00ZDaniel Kutyła
<ul></ul><p>New version: <a class="external" href="https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/a9a30db7ec9505450da696ccf660edc20fe2ac0b">https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/a9a30db7ec9505450da696ccf660edc20fe2ac0b</a><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-tests-workbench2/969"<a href="https://ci.arvados.org/job/developer-tests-workbench2/969/">developer-tests-workbench2: #969 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=969" alt="" /></a></a><br />Branch: 19311-Project-Search-field-auto-clears</p>
<p>Changed component type to a functional approach</p> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1072072022-10-19T13:36:13ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><ul>
<li>Manual tests show correct behavior.</li>
<li>There's some commented out code that could be just deleted.</li>
<li>On the test file <code>src/components/search-input/search-input.test.tsx</code> I'm not sure the modified test is correctly exercising the behavior, for example I tried commenting out line 101 and re-ran the test, still getting a success. I've even tried passing <code>setProps({ selfClearProp: 'abc' })</code> on line 101 and it also succeeds.</li>
</ul> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1072182022-10-19T17:27:37ZDaniel Kutyła
<ul></ul><p>New version: <a class="external" href="https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/cbe483113381e8c22b28a042479f5b7374a84744">https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/cbe483113381e8c22b28a042479f5b7374a84744</a><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-tests-workbench2/970/"<a href="https://ci.arvados.org/job/developer-tests-workbench2/970/">developer-tests-workbench2: #970 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=970" alt="" /></a></a><br />Branch: 19311-Project-Search-field-auto-clears</p>
<p>Removed commented code, made tests clear</p> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1072192022-10-19T17:38:28ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>I think tests like this should usually exercise both ways of a behavior: when it should and shouldn't happen.<br />I've added a commit (<a class="changeset" title="19311: Improves unit test. Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima@curi..." href="https://dev.arvados.org/projects/arvados-workbench-2/repository/arvados-workbench2/revisions/6887b04c343ddb0966415456774717cb38835fea">arvados-workbench2|6887b04c</a>) with the following:</p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/src/components/search-input/search-input.test.tsx b/src/components/search-input/search-input.test.tsx
index ff1d30c4..ba70f752 100644
</span><span class="gd">--- a/src/components/search-input/search-input.test.tsx
</span><span class="gi">+++ b/src/components/search-input/search-input.test.tsx
</span><span class="p">@@ -104,6 +104,11 @@</span> describe("<SearchInput />", () => {
expect(onSearch).toBeCalledWith("");
expect(onSearch).toHaveBeenCalledTimes(1);
+ // component should not clear on same selfClearProp
<span class="gi">+ searchInput.setProps({ selfClearProp: 'abc' });
+ jest.runTimersToTime(1000);
+ expect(onSearch).toHaveBeenCalledTimes(1);
+
</span> // component should clear on selfClearProp change
searchInput.setProps({ selfClearProp: '111' });
jest.runTimersToTime(1000);
</code></pre>
<p>...so that we make sure the cleaning is done only when it should.</p>
<p>With that, it LGTM.</p> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1072222022-10-19T19:56:38ZDaniel Kutyła
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset <a class="changeset" title="Merge branch '19311-Project-Search-field-auto-clears' into main closes #19311 Arvados-DCO-1.1-Si..." href="https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/10959e316a13cb2b55b139fb48c26654a96de9a3">arvados:arvados-workbench2|10959e316a13cb2b55b139fb48c26654a96de9a3</a>.</p> Arvados Workbench 2 - Bug #19311: Project Search field auto-clears on first query, making the user to re-type the query.https://dev.arvados.org/issues/19311?journal_id=1090952022-12-13T15:33:20ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>47</i></li></ul>