Arvados

Changes at d63d24c2ac7a88a83939e9fbaaf589540848ef7a branch 19319-container-price
Tests developer-tests-workbench2: #993

• Added "Container Cost" and "Container & Subprocess Cost"
• Hides cumulative cost when there are no subprocesses

Not sure if there are better names for the fields, I could also do "Workflow Cost" for cumulative, but that could be misleading since it wouldn't encompass the entire workflow when viewing a subprocess that has subprocesses

When I look at a queued/running container request, I get "00" in an off-brand font where the "Container Cost" label & field normally go. I suspect this is because the cost fields are zero, and "true && 0 && 'foo'" evaluates to 0 in js. Maybe we need "container.cost != 0" here?

                {container && container.cost && <Grid item xs={12} md={mdSize}>

Sometimes the cost fields appear when the process page first renders, then disappear. Sometimes they are missing at first and then appear after a few seconds. Is there a cache update race? Do we need to add the cost fields to a select param somewhere?

The capitalization of the existing field labels in the process panel seems haphazard ("Docker Image locator", "Output Collection", "Container run time") so it's impossible to make this one's capitalization match its neighbors. Personally I would choose "Docker image locator", "Output collection", "Container run time", "Container cost", etc., but anything consistent would be fine.

Come to think of it, the word "container" seems redundant -- can we just call it "Cost"?

I think it would be useful to also show the per-subprocess costs in the subprocess table down below, and show the cumulative costs in "all processes" and project views, but the way this issue is worded I guess those things are out of scope.

Changes at arvados-workbench2|e8f5f15c798460b3622dcd5dd1a1ced197ee1729
Tests developer-tests-workbench2: #994

• Fixed cost clearing due to loadcontainers not fetching cost field
• Changed checks to display cost fields to avoid leaking number values
• Normalized process attributes capitalization
• Renamed container cost to cost

LGTM, thanks!