Project

General

Profile

Actions

Feature #19319

closed

Display container price information

Added by Peter Amstutz 6 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
10/31/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

container_request -> cumulative_cost

container -> cost, subrequests_cost

Show two fields:

  • Cost of this container only
  • Cumulative cost of this container and all child containers

If there are 0 child processes, don't show the 2nd field.


Subtasks 1 (0 open1 closed)

Task #19445: Review 19319-container-priceResolvedStephen Smith10/31/2022

Actions

Related issues

Blocked by Arvados - Feature #18205: [api] [cloud] add compute instance price to container recordResolvedTom Clegg08/08/2022

Actions
Actions #1

Updated by Peter Amstutz 6 months ago

  • Blocked by Feature #18205: [api] [cloud] add compute instance price to container record added
Actions #2

Updated by Peter Amstutz 6 months ago

  • Target version changed from 2022-09-14 sprint to 2022-08-31 sprint
Actions #3

Updated by Peter Amstutz 6 months ago

  • Target version changed from 2022-08-31 sprint to 2022-09-14 sprint
Actions #4

Updated by Peter Amstutz 5 months ago

  • Assigned To set to Stephen Smith
Actions #5

Updated by Peter Amstutz 5 months ago

  • Target version changed from 2022-09-14 sprint to 2022-10-12 sprint
Actions #6

Updated by Peter Amstutz 4 months ago

  • Target version changed from 2022-10-12 sprint to 2022-10-26 sprint
Actions #7

Updated by Peter Amstutz 4 months ago

  • Target version changed from 2022-10-26 sprint to 2022-11-09 sprint
Actions #8

Updated by Peter Amstutz 3 months ago

  • Description updated (diff)
Actions #9

Updated by Stephen Smith 3 months ago

  • Status changed from New to In Progress
Actions #10

Updated by Stephen Smith 3 months ago

Changes at d63d24c2ac7a88a83939e9fbaaf589540848ef7a branch 19319-container-price
Tests developer-tests-workbench2: #993

  • Added "Container Cost" and "Container & Subprocess Cost"
  • Hides cumulative cost when there are no subprocesses

Not sure if there are better names for the fields, I could also do "Workflow Cost" for cumulative, but that could be misleading since it wouldn't encompass the entire workflow when viewing a subprocess that has subprocesses

Actions #11

Updated by Tom Clegg 3 months ago

When I look at a queued/running container request, I get "00" in an off-brand font where the "Container Cost" label & field normally go. I suspect this is because the cost fields are zero, and "true && 0 && 'foo'" evaluates to 0 in js. Maybe we need "container.cost != 0" here?

                {container && container.cost && <Grid item xs={12} md={mdSize}>

Sometimes the cost fields appear when the process page first renders, then disappear. Sometimes they are missing at first and then appear after a few seconds. Is there a cache update race? Do we need to add the cost fields to a select param somewhere?

The capitalization of the existing field labels in the process panel seems haphazard ("Docker Image locator", "Output Collection", "Container run time") so it's impossible to make this one's capitalization match its neighbors. Personally I would choose "Docker image locator", "Output collection", "Container run time", "Container cost", etc., but anything consistent would be fine.

Come to think of it, the word "container" seems redundant -- can we just call it "Cost"?

I think it would be useful to also show the per-subprocess costs in the subprocess table down below, and show the cumulative costs in "all processes" and project views, but the way this issue is worded I guess those things are out of scope.

Actions #12

Updated by Stephen Smith 3 months ago

Changes at arvados-workbench2|e8f5f15c798460b3622dcd5dd1a1ced197ee1729
Tests developer-tests-workbench2: #994

  • Fixed cost clearing due to loadcontainers not fetching cost field
  • Changed checks to display cost fields to avoid leaking number values
  • Normalized process attributes capitalization
  • Renamed container cost to cost
Actions #13

Updated by Tom Clegg 3 months ago

LGTM, thanks!

Actions #14

Updated by Stephen Smith 3 months ago

  • Status changed from In Progress to Resolved
Actions #15

Updated by Peter Amstutz about 2 months ago

  • Release set to 47
Actions

Also available in: Atom PDF