Arvados

19364-diag-docs LGTM if it's only intended to document the use of diagnostics.

Are the other checks listed on the title already documented, or will be on other branches?

The diagnostics command incorporates a health-check, so in that sense it's included.

• a page (in the Admin>Monitoring section?) about the diagnostics command, similar to the "Testing cloud configuration" page
• a bit about the "arvados-server health" command on the Admin > Monitoring > Health checks page

developer-run-tests: #3384

• add Admin > Monitoring > Diagnostics page
• add "arvados-server check" to the Admin > Monitoring > Health checks page

merged main to get lib/pam testing fix.

19364-diag-docs @ 531fd553a1b83c546066c1d2a2619f86e17b6d20 -- developer-run-tests: #3385

Just one comment:

• At doc/admin/diagnostics.html.textile.liquid I think the "using" word could be dropped at "...you can also run diagnostics using by setting the usual..."

The rest LGTM, thanks.

On a "diagnostics"-related note: Do you think it's a good idea to make the diagnostics tool to cancel the test container request when the 10min timeout passes and nothing happened? In my terraform adventures it happened that an instance is launched but then it couldn't run anything so the diag tool fails at the 10 minute mark and the instance isn't destroyed unless I manually cancelled the CR in workbench (maybe the dispatcher will eventually kill it?)

Removed extra "using" word in docs.

"Cancel CR if it doesn't finish" is a great idea -- added.

(In the particular case you described I think MaxDispatchAttempts would have canceled it eventually -- but either way, it seems like there's no reason for the dispatcher to keep trying once diagnostics has stopped paying attention.)

19364-diag-docs @ 273d4dda75bad4b1ba18bc3616f16082b95c0467 -- developer-run-tests: #3390

Great! this LGTM, thank you.