Arvados

Updates at 4a499571f - branch 19400-login-sync-logincluster
Test run: developer-run-tests: #3277

• Adds method to Ruby SDK's Arvados class to request the cluster's exported config.
• Makes login-sync detect LoginCluster federations and query the appropriate cluster when creating/checking tokens.
• Updates documentation, including upgrade notes.

Ok, all tests failed because login-sync's install phase couldn't be completed. Probably because of its new requirement on the arvados gem. Maybe I should split the branch in 2, and commit the Ruby SDK's changes first.

Split the previous branch. Created 19400-rubysdk-cluster-config with only the Ruby SDK's new method at 4fb2e88
Test run: developer-run-tests: #3300

Branch 19400-login-sync-logincluster at 084c954 -- rebased to 19400-rubysdk-cluster-config
Test run: waiting for 19400-rubysdk-cluster-config to be merged first so that the dependency requirement doesn't fail.

I believe the dependency in 19400-login-sync-logincluster needs to be changed to "> 2.4.3"

I believe the development build is versioned as 2.4.4dev123, so once the ruby sdk is merged it should work fine?

Rest LGTM.

Peter Amstutz wrote in #note-16:

I believe the dependency in 19400-login-sync-logincluster needs to be changed to "> 2.4.3"

Thanks, I forgot to update the dependency with the newer release. Done in 7ce7361f6

I believe the development build is versioned as 2.4.4dev123, so once the ruby sdk is merged it should work fine?

I think so, yes.
Merged 19400-rubysdk-cluster-config to main, and will wait for the package to be built before running tests.

After having a success arvados gem build (build-packages-python-ruby: #2456 ), the test run on the 19400-login-sync-logincluster branch still fails because it doesn't find the correct gem version: developer-run-tests: #3307

Updates at 7ebb93e - branch 19400-login-sync-logincluster
Test run: developer-run-tests: #3314

• Adds a "pre-release" type of dependency to login-sync to prove that we won't be able to make it use a X.Y.Z.devNNNN arvados gem unless we explicitly ask for it, for example like this:

s.add_runtime_dependency 'arvados', '~> 2.4', '> 2.4.3a'

(note the 'a' suffix, makes it match a pre-release gem)

Source:

• https://github.com/rubygems/bundler/issues/2938
• https://github.com/rubygems/bundler/issues/4340

Tests above failed because it seems that the newly built arvados gem isn't explicitly installed on the developer-test-run-reminder pipeline.

Updates at d10a5d8
Test run: developer-run-tests: #3316

• Explicitly installs Ruby SDK gem when on the login-sync install phase.

I tried on a fresh rvm gemset to install this gem and it installed the arvados v2.4.3 version from rubygems:

$ gem install arvados-login-sync-2.5.0.dev20221012195706.gem
Fetching ruby2_keywords-0.0.5.gem
Fetching faraday-0.17.5.gem
Fetching jwt-1.5.6.gem
...
Fetching arvados-2.4.3.gem
...
Successfully installed arvados-2.4.3
Successfully installed arvados-login-sync-2.5.0.dev20221012195706
...
24 gems installed

So I think this could be the solution, although we might need to adjust the dependency to ask for '> 2.4.4a' to avoid making it use 2.4.3 on preexisting environments.

Updates at 1227556ee
Test run: developer-run-tests-remainder: #3481

• Changes the arvados gem dependency to "> 2.4.4a" so that it doesn't pull the 2.4.3 version on preexisting environments:

lucas@buster:~/arvados/services/login-sync$ gem build arvados-login-sync.gemspec
  Successfully built RubyGem
  Name: arvados-login-sync
  Version: 2.5.0.dev20221012195706
  File: arvados-login-sync-2.5.0.dev20221012195706.gem
lucas@buster:~/arvados/services/login-sync$ gem install arvados-login-sync-2.5.0.dev20221012195706.gem
ERROR:  Could not find a valid gem 'arvados' (~> 2.4, > 2.4.4a) (required by 'arvados-login-sync-2.5.0.dev20221012195706.gem' (>= 0)) in any repository
ERROR:  Possible alternatives: arvados

Lucas Di Pentima wrote in #note-22:

Updates at 1227556ee
Test run: developer-run-tests-remainder: #3481

• Changes the arvados gem dependency to "> 2.4.4a" so that it doesn't pull the 2.4.3 version on preexisting environments:

[...]

great! this LGTM