Project

General

Profile

Actions

Bug #19421

closed

Restore "redirectTo" to avoid breaking existing URLs

Added by Peter Amstutz about 1 month ago. Updated 9 days ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Story points:
-
Release relationship:
Auto

Description

Hi,

It seems that to solve the issue #19153 (inline HTML viewing) the URLs generated by the "Copy to clipboard" context menu have changed-

Now:
https://wb2.xxxxx.example.com?redirectToPreview=/c=xxxxx-4zz18-xxxxxxxxxxxxxxx/somefile.txt

Before:
https://wb2.xxxxx.example.com?redirectTo=/c=xxxxx-4zz18-xxxxxxxxxxxxxxx/somefile.txt

Users put these URLs on Slides for Scientists and are complaining now that these links are broken. Is there any good reason why this URL was changed? It does not seem to make a difference if it's a file that can be displayed inline or not.

Actions #1

Updated by Peter Amstutz about 1 month ago

  • Status changed from New to In Progress
Actions #2

Updated by Peter Amstutz about 1 month ago

  • Description updated (diff)
Actions #4

Updated by Peter Amstutz about 1 month ago

Stephen Smith wrote in #note-3:

Changes at arvados-workbench2|98d3f7708860701b02055643da4ba9412720bf4b branch 19421-restore-old-redirect-key
Tests developer-tests-workbench2: #863

        case href.indexOf(`${REDIRECT_TO_KEY}=`) > -1:

Using `${}` for a string constant seems redundant.

I wish these URL manipulations used something like the URL API to inspect "searchParams" instead of brittle string munging. Looks like Danny wrote this originally, we should check with him, maybe he had a good reason.

Otherwise this is probably fine to merge

Actions #5

Updated by Stephen Smith about 1 month ago

  • Status changed from In Progress to Resolved
  • Keeping the template string for readability while matching the `=` at the end

Merged in arvados-workbench2|32fbcbb4677d149cd0ef0b5c5eead1c9fa25ef5f

Actions #6

Updated by Peter Amstutz 13 days ago

  • Release set to 53
Actions #7

Updated by Moritz Gilsdorf 9 days ago

Testing 2.4.3. The Alias from ?redirectTo= to ?redirectToPreview= is working. However the WB2 is still issuing ?redirectToPreview= links with the "Copy to clipboard" menu. Why not issuing ?redirectTo= links like before?

Actions

Also available in: Atom PDF