Project

General

Profile

Actions

Feature #19466

closed

Record input & output object on workflow steps as container request property

Added by Peter Amstutz 5 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
CWL
Target version:
Start date:
10/06/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Subtasks 1 (0 open1 closed)

Task #19596: Review 19466-cwl-ioResolvedPeter Amstutz10/06/2022

Actions

Related issues

Related to Arvados - Feature #16073: [Process view] Panels for inputs and outputsResolvedStephen Smith07/22/2022

Actions
Actions #1

Updated by Peter Amstutz 5 months ago

  • Category set to CWL
Actions #2

Updated by Peter Amstutz 5 months ago

  • Target version changed from 2022-09-28 sprint to 2022-10-12 sprint
Actions #3

Updated by Peter Amstutz 4 months ago

  • Target version changed from 2022-10-12 sprint to 2022-10-26 sprint
Actions #4

Updated by Peter Amstutz 4 months ago

  • Target version changed from 2022-10-26 sprint to 2022-10-12 sprint
Actions #5

Updated by Peter Amstutz 4 months ago

  • Assigned To set to Peter Amstutz
Actions #6

Updated by Peter Amstutz 4 months ago

  • Related to Feature #16073: [Process view] Panels for inputs and outputs added
Actions #7

Updated by Peter Amstutz 4 months ago

19466-cwl-io @ 210f068ee8ba5b6f56459ba2f14c86b59385b29b

Example here: https://workbench2.ce8i5.arvadosapi.com/processes/ce8i5-xvhdp-jx0dihjon1kflll

I'm pretty sure I need to update tests before this is ready for review, but the actual feature is quite simple.

Actions #8

Updated by Peter Amstutz 4 months ago

  • Status changed from New to In Progress
Actions #9

Updated by Peter Amstutz 4 months ago

19466-cwl-io @ a7caca5452e7ece2ea3f6efd3ab4bb992c1f31fb

  • record cwl_input and cwl_output in container request properties for workflow steps
  • does not record it on the top level workflow because that information is already available a different way and I'd prefer to avoid duplicating it

developer-run-tests: #3311

Actions #10

Updated by Lucas Di Pentima 4 months ago

Just a couple of questions:

  • All test fixes are related to properties['cwl_input'], should we add some test to exercise the cwl_output part of this?
  • What's the utility of recording this? I mean, will this data be consumed only by machines or should we document the feature for humans to know about it?

The rest LGTM

Actions #11

Updated by Peter Amstutz 4 months ago

  • Target version changed from 2022-10-12 sprint to 2022-10-26 sprint
Actions #12

Updated by Peter Amstutz 3 months ago

Lucas Di Pentima wrote in #note-10:

Just a couple of questions:

  • All test fixes are related to properties['cwl_input'], should we add some test to exercise the cwl_output part of this?

I added a check for cwl_output to one test, thanks.

  • What's the utility of recording this? I mean, will this data be consumed only by machines or should we document the feature for humans to know about it?

We didn't have a page that documents the properties used by the system, so I wrote one and added it to the API section.

In the process I also found that to avoid breaking "strict" vocabulary enforcement, I probably need to add these to the list of system properties in the vocabulary checker, so I did.

The rest LGTM

If you're happy with the documentation page let me know & I'll merge.

19466-cwl-io @ c634fdaf04b09ccd64d418c37dddc1eb7ff1c490

developer-run-tests: #3333

Actions #13

Updated by Lucas Di Pentima 3 months ago

Just one small suggestion:

  • I think it would be nice to link the "see below" comment on collection type properties, to future proof navigation in case this page eventually gets too long.

The rest LGTM, thanks!

Actions #14

Updated by Peter Amstutz 3 months ago

  • Status changed from In Progress to Resolved
Actions #15

Updated by Peter Amstutz about 2 months ago

  • Release set to 47
Actions

Also available in: Atom PDF