https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422022-10-28T20:05:12ZArvadosArvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1074952022-10-28T20:05:12ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> set to <i>2022-11-09 sprint</i></li><li><strong>Assigned To</strong> set to <i>Peter Amstutz</i></li><li><strong>Category</strong> set to <i>Workbench2</i></li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1075662022-11-01T21:20:37ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2022-11-09 sprint</i> to <i>2022-11-23 sprint</i></li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1077312022-11-08T19:30:58ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2022-11-23 sprint</i> to <i>2022-12-07 Sprint</i></li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1081672022-11-18T21:47:51ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2022-12-07 Sprint</i> to <i>2022-12-21 Sprint</i></li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1083862022-11-23T18:12:26ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2022-12-21 Sprint</i> to <i>2023-01-18 sprint</i></li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1084322022-11-23T18:33:21ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2023-01-18 sprint</i> to <i>2023-02-01 sprint</i></li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1094842023-01-03T17:50:24ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Category</strong> changed from <i>Workbench2</i> to <i>Workbench2</i></li><li><strong>Subject</strong> changed from <i>can't give someone a link to registered wf in wb2</i> to <i>Linkable view panel for registered workflows</i></li><li><strong>Project</strong> changed from <i>Arvados Workbench 2</i> to <i>Arvados</i></li><li><strong>Tracker</strong> changed from <i>Bug</i> to <i>Feature</i></li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1096722023-01-11T17:57:02ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2023-02-01 sprint</i> to <i>Future</i></li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1106752023-02-02T13:35:06ZSarah Zaranekswz@curii.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-6 status-1 priority-4 priority-default" href="/issues/20059">Idea #20059</a>: Redesign Register Workflow Panel</i> added</li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1108832023-02-13T14:57:26ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/110883/diff?detail_id=107658">diff</a>)</li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1108852023-02-13T15:13:43ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Blocks</strong> <i><a class="issue tracker-2 status-1 priority-4 priority-default" href="/issues/20094">Feature #20094</a>: Render workflow with cwl-svg</i> added</li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1108872023-02-13T15:14:07ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/110887/diff?detail_id=107662">diff</a>)</li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1110842023-02-14T19:09:29ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Story points</strong> set to <i>2.5</i></li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1110852023-02-14T19:11:29ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/111085/diff?detail_id=107856">diff</a>)</li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1110862023-02-14T19:13:36ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/111086/diff?detail_id=107857">diff</a>)</li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1110872023-02-14T19:15:28ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/111087/diff?detail_id=107858">diff</a>)</li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1110882023-02-14T19:15:54ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>Future</i> to <i>2023-03-01 sprint</i></li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1126492023-02-23T18:55:14ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>57</i></li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1126522023-02-23T19:17:54ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Right-justify Run button.</p>
<p>Add three dot action menu.</p>
<p>Add standard items to context menu.</p>
<p>Fix breadcrumbs.</p> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1126592023-02-23T23:07:38ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-3 priority-4 priority-default closed" href="/issues/19932">Bug #19932</a>: CLI, python, CURL examples show every example code twice</i> added</li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1127762023-02-28T16:31:15ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>19482-wf-panel @ <a class="changeset" title="19482: Fix tests Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>" href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/c3bc34209f7dbbc80c62d8896af043c88cb6b9cf">c3bc34209f7dbbc80c62d8896af043c88cb6b9cf</a></p>
<p><a class="external" href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/1111/"<a href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/1111/">developer-tests-workbench2: #1111 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=1111" alt="" /></a></a></p>
<ul>
<li>Adds new route for workflow panel</li>
<li>Displays details, Inputs, Outputs, and contents of the collection containing the workflow</li>
<li>Context menu now has basic operations on workflow record</li>
</ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1127792023-02-28T16:31:48ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1128032023-03-01T14:55:09ZStephen Smith
<ul></ul><p>Aside from a couple notes it lgtm:</p>
<ul>
<li>The breadcrumbs don't show the workflow you are currently viewing as the last item similar to other areas - the parent location should probably be blue / link color similar to other pages since it navigates to a different location</li>
<li>There seems to be some extra padding making the details card icon in the top left out of alignment with the other cards</li>
<li>Not sure if it's intentional for now but the back button after pressing run process returns to the old run process multi step form</li>
</ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1128602023-03-02T20:09:00ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2023-03-01 sprint</i> to <i>Development 2023-03-15 sprint</i></li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1130362023-03-07T22:16:34ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>File</strong> <a href="/attachments/3271">Screenshot from 2023-03-07 16-56-54.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/3271/Screenshot%20from%202023-03-07%2016-56-54.png">Screenshot from 2023-03-07 16-56-54.png</a> added</li></ul><p>Stephen Smith wrote in <a href="#note-23">#note-23</a>:</p>
<blockquote>
<p>Aside from a couple notes it lgtm:</p>
<ul>
<li>The breadcrumbs don't show the workflow you are currently viewing as the last item similar to other areas - the parent location should probably be blue / link color similar to other pages since it navigates to a different location</li>
</ul>
</blockquote>
<p>I'm confused, you should be seeing the name of the workflow, was there some way you navigated to it that didn't work?</p>
<p><img src="https://dev.arvados.org/attachments/download/3271/Screenshot%20from%202023-03-07%2016-56-54.png" alt="" /></p>
<blockquote>
<ul>
<li>There seems to be some extra padding making the details card icon in the top left out of alignment with the other cards</li>
</ul>
</blockquote>
<p>Good catch, I copied styling from collection panel when I should have copied it from the process panel. The collection panel has the same issue and to ensure consistent styling it should be migrated to use CardHeader/CardContent instead of just Grid.</p>
<blockquote>
<ul>
<li>Not sure if it's intentional for now but the back button after pressing run process returns to the old run process multi step form</li>
</ul>
</blockquote>
<p>I tried this and it took me back to the workflow panel? But I know navigation is a bit fussy.</p> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1130942023-03-08T21:51:13ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>19482-wf-panel @ <a class="changeset" title="19482: Use CardHeader/CardContent for more consistent styling Arvados-DCO-1.1-Signed-off-by: Pet..." href="https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/cd89fd24a8cdf7512a4352f1fc17101b225e32c4">arvados-workbench2|cd89fd24a8cdf7512a4352f1fc17101b225e32c4</a></p>
<p>Registered workflow panel and Collection panel use CardHeader/CardContent for more consistent styling.</p> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1131252023-03-10T16:37:48ZStephen Smith
<ul><li><strong>File</strong> <a href="/attachments/3276">simplescreenrecorder-2023-03-10_11.25.21.crop.mp4</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/3276/simplescreenrecorder-2023-03-10_11.25.21.crop.mp4">simplescreenrecorder-2023-03-10_11.25.21.crop.mp4</a> added</li><li><strong>File</strong> <a href="/attachments/3275">simplescreenrecorder-2023-03-10_11.29.09.mp4</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/3275/simplescreenrecorder-2023-03-10_11.29.09.mp4">simplescreenrecorder-2023-03-10_11.29.09.mp4</a> added</li></ul><p>For the breadcrumbs, I started by navigating directly to the workflow url (/workflows/tordo-7fd4e-8kruxiw4pv5huh3), it works fine when I look at a collection in the same project, and the parent project shows up fine in the sidebar as well, but navigating to the workflow consistently doesn't show the item - the side panel parent project also loses the blue highlight so that might be related.</p>
<p>I also added a video of the wf run form back button issue, I can press the browser back button to get back to the wf panel but the form back button goes back to the workflow selector</p> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1132732023-03-15T15:30:11ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>Development 2023-03-15 sprint</i> to <i>Development 2023-03-29 Sprint</i></li></ul> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1134272023-03-23T15:00:30ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Stephen Smith wrote in <a href="#note-27">#note-27</a>:</p>
<blockquote>
<p>For the breadcrumbs, I started by navigating directly to the workflow url (/workflows/tordo-7fd4e-8kruxiw4pv5huh3), it works fine when I look at a collection in the same project, and the parent project shows up fine in the sidebar as well, but navigating to the workflow consistently doesn't show the item - the side panel parent project also loses the blue highlight so that might be related.</p>
</blockquote>
<p>I finally figured out why I couldn't reproduce it, we're looking at exactly the same workflow but you're looking at it in the "Shared with me" tree. When I look at something else in "Shared with me" I see the same behavior. Will fix.</p>
<blockquote>
<p>I also added a video of the wf run form back button issue, I can press the browser back button to get back to the wf panel but the form back button goes back to the workflow selector</p>
</blockquote>
<p>Ok. The browser back button does the right thing, but that "back" button at the bottom of the page is something else entirely. I'm not entirely sure there is a sensible fix here because that button works by switching the state to "step 1" rather than "navigate back". What do you think about just leaving it as-is? The plan is to rework Workflow launching and get rid of the two-step interface entirely in favor of creating an container request and editing it in place.</p> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1134412023-03-24T15:20:58ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>19482-wf-panel @ <a class="changeset" title="19482: Fix breadcrumbs to display properly when directly navigating Arvados-DCO-1.1-Signed-off-b..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/bf2e7c937e911629122eec14c29e8f6fa9b84aa6">bf2e7c937e911629122eec14c29e8f6fa9b84aa6</a></p>
<p><a class="external" href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/1168/"<a href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/1168/">developer-tests-workbench2: #1168 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=1168" alt="" /></a></a></p>
<ul>
<li>Fixed breadcrumbs for Workflow panel. Also fixed first-time-load breadcrumb display for collections and processes because they had similar issues.</li>
</ul>
<p>I'm not completely happy with the existing architecture, this feels like something where the breadcrumb control be tasked with monitoring the currently item and working backwards to determine how to correctly render breadcrumbs, without requiring an explicit resource-specific "load" function. Getting this right was much trickier than it should have been.</p> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1134512023-03-24T19:48:19ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Don't know if it is a flaky test or I broke something, re-running here</p>
<p><a class="external" href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/1169/"<a href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/1169/">developer-tests-workbench2: #1169 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=1169" alt="" /></a></a></p> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1134662023-03-27T19:49:21ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Looks like flaky tests, maybe the breadcrumb changes messed up timing, I made some fixes:</p>
<p><a class="external" href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/1170/"<a href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/1170/">developer-tests-workbench2: #1170 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=1170" alt="" /></a></a></p> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1134672023-03-27T20:41:38ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>try again 19482-wf-panel @ <a class="changeset" title="19482: Fix more flaky tests Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>" href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/fc02bef10c31adcad5ef912979d43a56dc9741ad">fc02bef10c31adcad5ef912979d43a56dc9741ad</a></p>
<p><a class="external" href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/1171/"<a href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/1171/">developer-tests-workbench2: #1171 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=1171" alt="" /></a></a></p> Arvados - Feature #19482: Linkable view panel for registered workflowshttps://dev.arvados.org/issues/19482?journal_id=1134712023-03-28T13:48:40ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul>